FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-87790: support thousands separators for formatting fractional part of Fraction by skirpichev · Pull Request #132204 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-87790: support thousands separators for formatting fractional part of Fraction - #132204

Merged
hugovk merged 2 commits into
python:mainfrom
skirpichev:frac-sep-Fraction/87790
Jul 7, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-87790: support thousands separators for formatting fractional part of Fraction#132204
hugovk merged 2 commits into
python:mainfrom
skirpichev:frac-sep-Fraction/87790

Conversation

skirpichev commented Apr 7, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 7, 2025
Closed
serhiy-storchaka reviewed Jul 3, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Test also errors for '.f' and '.6_f'.

skirpichev commented Jul 3, 2025

Copy link
Copy Markdown
Member Author

Test also errors for '.f' and '.6_f'.

I suspect you are about ._6f. This test was added in test_invalid_formats(). Missing precision already was tested.

serhiy-storchaka requested a review from hugovk July 3, 2025 13:02
serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Jul 3, 2025
serhiy-storchaka approved these changes Jul 3, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

hugovk changed the title gh-87790: support thousands separators for formatting fractional part of Fraction's gh-87790: support thousands separators for formatting fractional part of Fraction Jul 7, 2025
hugovk merged commit 3e849d7 into python:main Jul 7, 2025

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e849d75f400569cbf3c29c356061c788284b71e 3.14

skirpichev deleted the frac-sep-Fraction/87790 branch July 7, 2025 08:58
skirpichev added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 7, 2025

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e849d75f400569cbf3c29c356061c788284b71e 3.14

serhiy-storchaka added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 7, 2025

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
pythongh-87790: support thousands separators for formatting fractiona…
8e54f7a 
…l part of Fraction (pythonGH-132204)

(cherry picked from commit 3e849d7)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136364 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
[3.14] gh-87790: support thousands separators for formatting fraction…
442b781 
…al part of Fraction (GH-132204) (#136364)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-87790: support thousands separators for formatting fractiona…
d2730af 
…l part of Fraction (python#132204)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-87790: support thousands separators for formatting fractiona…
8c96584 
…l part of Fraction (python#132204)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-87790: support thousands separators for formatting fractiona…
51c7b1a 
…l part of Fraction (python#132204)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-87790: support thousands separators for formatting fractiona…
a9f7faa 
…l part of Fraction (python#132204)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-87790: support thousands separators for formatting fractiona…
e5508f9 
…l part of Fraction (python#132204)
scoder added a commit to scoder/quicktions that referenced this pull request Sep 8, 2025
Support thousands separators for formatting fractional part of Fraction.
5392ea2 
See python/cpython#132204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
picnixz Awaiting requested review from picnixz
hugovk Awaiting requested review from hugovk

Assignees

hugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL