You're welcome! I've just seen that I've exposed the function using PyAPI_FUNC but I think an extern is sufficient. I'll amend this and then merge it.

Mmh, the JIT tells me that it needs to be exported using PyAPI_FUNC. Well.. TIL.

@brandtbucher Can you tell me why the JIT wouldn't work with extern here? (I'll change the symbol visibility but I'm interested in learning the reason)

Sure! Very basically, the JIT code isn’t part of the same compilation unit as the rest of the interpreter, since it’s loaded at runtime. Because of that, the code it emits is like that of a third-party extension module.

So this requires the symbols the JIT code “links” against to be visible at runtime. extern is only useful for code that’s linked as part of the interpreter itself.

Oh I see. Thanks for the explanation. I'll add a small comment about the reason why we need PyAPI_FUNC then.

Thanks. And you can just leave it in the internal API too (pycore_*). Just because we change the symbol visibility doesn’t mean it needs to be a supported API for third-party extensions.

And you can just leave it in the internal API too (pycore_*)

The new function is already in Include/internal/pycore_ceval.h. Were you thinking of another place?

Nope, just making sure you knew it didn’t need to be moved!

🎉🙏