gh-131507: Remove Misc/mypy symlinks from the repository - #132270
Conversation
Sorry, something went wrong.
They would end up in source tarballs and consequently in the SBOM. We don't want that.
| @@ -0,0 +1,5 @@ | |||
| # This list is also used in make_symlinks.py, only put actual concrete paths below | |||
There was a problem hiding this comment.
It's a pity .gitignore doesn't let you include other files.
Sorry, something went wrong.
| operating systems without symlink support. Additionally, those symlinks | ||
| would have to be part of the SBOM, which we don't want either. | ||
|
|
||
| Instead, this directory ships with a `make_symlinks.py` script, which |
There was a problem hiding this comment.
FWIW, I would be inclined to not symlink anything, and instead copy files to a separate directory to run mypy on... but then I don't use mypy and I have no idea how that would integrate with normal edit-typecheck workflows people have.
Sorry, something went wrong.
There was a problem hiding this comment.
copying files makes it annoying for a local workflow since then you have to copy the tree for every mypy run. that's too slow.
Sorry, something went wrong.
|
I'm going with #132274 instead. |
Sorry, something went wrong.
They would end up in source tarballs and consequently in the SBOM. We don't want that.