FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132415: Bump the setuptools in test.wheeldata by stefanor · Pull Request #132382 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-132415: Bump the setuptools in test.wheeldata - #132382

Closed
stefanor wants to merge 2 commits into
python:mainfrom
stefanor:bump-setuptools
ConversationCommits (2)ChecksFiles changed
Closed

gh-132415: Bump the setuptools in test.wheeldata#132382
stefanor wants to merge 2 commits into
python:mainfrom
stefanor:bump-setuptools

Conversation

stefanor commented Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

setuptools > 70.1 includes bdist_wheel, so we no longer need to bundle wheel.

Fixes: #132415

Bump the setuptools in test.wheeldata
f9430dd 
setuptools > 70.1 includes bdist_wheel, so we no longer need to bundle
wheel.

brianschubert commented Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Can you open an issue explaining the reason for this change? Issues usually aren't required for test-only changes, but since this is touching binary files, it might benefit from more visibility / coordination.

Note that if a binary file needs to be changed, that generally needs to be done by a trusted individual (e.g. a setuptools maintainer).

ZeroIntensity added tests Tests in the Lib/test dir skip news skip issue labels Apr 11, 2025

stefanor commented Apr 11, 2025

Copy link
Copy Markdown
Contributor Author

Can you open an issue explaining the reason for this change?

I thought an update and simplification would be reason enough on it's own, but sure :)

Note that if a binary file needs to be changed, that generally needs to be done by a trusted individual (e.g. a setuptools maintainer).

Sure, I'll run this past them.

stefanor changed the title Bump the setuptools in test.wheeldata GH-132415: Bump the setuptools in test.wheeldata Apr 11, 2025

stefanor commented Apr 11, 2025

Copy link
Copy Markdown
Contributor Author

Can you open an issue explaining the reason for this change?

Filed #132415

Add missing sys import in the limited ABI branch
933df04 
Triggered by setuptools 78.1.0, the branch must have been unused before.
AA-Turner mentioned this pull request Apr 24, 2025
Closed
zware changed the title GH-132415: Bump the setuptools in test.wheeldata gh-132415: Bump the setuptools in test.wheeldata Apr 24, 2025

AA-Turner commented Apr 24, 2025

Copy link
Copy Markdown
Member

Closing in favour of #132887.

AA-Turner closed this Apr 24, 2025
stefanor deleted the bump-setuptools branch April 25, 2025 01:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

awaiting review skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update bundled setupotools in test.wheeldata and remove wheel.whl

4 participants

Back | FazBrowse Home | New Git URL