FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132396: address `redefinition of unused name` errors in `Lib/test` by picnixz · Pull Request #132397 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-132396: address redefinition of unused name errors in Lib/test - #132397

Merged
AA-Turner merged 17 commits into
python:mainfrom
picnixz:lint/tests/ruff-redef-unused-names
Apr 18, 2025
ConversationCommits (17)ChecksFiles changed
Merged

gh-132396: address redefinition of unused name errors in Lib/test#132397
AA-Turner merged 17 commits into
python:mainfrom
picnixz:lint/tests/ruff-redef-unused-names

Conversation

picnixz commented Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

There was a duplicated test, namely test_dataclass_derived_generic_from_slotted_base, which I've fixed in #132516.

bedevere-app Bot mentioned this pull request Apr 11, 2025
Closed

picnixz commented Apr 11, 2025

Copy link
Copy Markdown
Member Author

cc @hugovk @AA-Turner: I've left this PR as a draft to avoid mentioning many code owners

AA-Turner reviewed Apr 11, 2025
View reviewed changes

AA-Turner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All of the noqa comments seems like a lot of noise in these test files, and I'm not sure how much benefit we gain?

Comment thread Lib/test/.ruff.toml Outdated
Comment thread Lib/test/.ruff.toml Outdated
Comment thread Lib/test/.ruff.toml Outdated

picnixz commented Apr 12, 2025

Copy link
Copy Markdown
Member Author

All of the noqa comments seems like a lot of noise in these test files

Indeed, but at the same they allowed me to find two tests with the same name. So... unless we just noqa-them globally we wouldn't be able to see future ones (and thus it wouldn't help at all =/)

picnixz and others added 4 commits April 12, 2025 02:09
Update Lib/test/.ruff.toml
2a09ca0 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Update Lib/test/.ruff.toml
c816e39 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Update Lib/test/.ruff.toml
de5edc7 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
revert most of noqa: F811 false positive (fixed upstream)
484cfd0

picnixz commented Apr 14, 2025

Copy link
Copy Markdown
Member Author

By bumping the ruff version, it appears that the code that would raise is now correctly marked as "unreachable", so suppression is no more an issue. To minimize the diff I've marked all variables with a single letter as being dummy (that way, we ignore classes of the form class A that are usually dummy classes).

picnixz marked this pull request as ready for review April 14, 2025 14:35

picnixz commented Apr 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

To have a cleaner, I'll isolate the test fix for test_dataclass_derived_generic_from_slotted_base which was duplicated.

See #132516. Once it's merged, we can revert the commit.

picnixz requested review from AA-Turner and removed request for ericvsmith April 14, 2025 15:08
brettcannon removed their request for review April 14, 2025 17:01
AlexWaygood reviewed Apr 15, 2025
View reviewed changes
Comment thread Lib/test/.ruff.toml Outdated
picnixz requested a review from AlexWaygood April 18, 2025 09:42
picnixz changed the title gh-132396: ignore some redefinition of unused name errors in Lib/test gh-132396: address redefinition of unused name errors in Lib/test Apr 18, 2025
AlexWaygood approved these changes Apr 18, 2025
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

AA-Turner merged commit 1d5dc5f into python:main Apr 18, 2025

hugovk commented Apr 18, 2025

Copy link
Copy Markdown
Member

And backport?

AA-Turner added the needs backport to 3.13 only security fixes label Apr 18, 2025

miss-islington-app Bot commented Apr 18, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 18, 2025
pythongh-132396: Resolve 'redefinition of unused name' errors in ``Li…
da99afe 
…b/test/`` (pythonGH-132397)

(cherry picked from commit 1d5dc5f)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Apr 18, 2025

Copy link
Copy Markdown

GH-132699 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 18, 2025
picnixz deleted the lint/tests/ruff-redef-unused-names branch April 18, 2025 18:28
AA-Turner added a commit that referenced this pull request Apr 18, 2025
[3.13] gh-132396: Resolve 'redefinition of unused name' errors in ``L…
10f37b3 
…ib/test/`` (GH-132397) (#132699)

gh-132396: Resolve 'redefinition of unused name' errors in ``Lib/test/`` (GH-132397)
(cherry picked from commit 1d5dc5f)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
AA-Turner AA-Turner approved these changes
AlexWaygood AlexWaygood approved these changes
ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL