FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132097: use a macro for semantically casting function pointers by picnixz · Pull Request #132406 · python/cpython · GitHub

/ cpython Public

gh-132097: use a macro for semantically casting function pointers - #132406

Merged
picnixz merged 8 commits into
python:mainfrom
picnixz:feat/ubsan/explicit-conversions
Apr 18, 2025
ConversationCommits (8)ChecksFiles changed
Merged

gh-132097: use a macro for semantically casting function pointers#132406
picnixz merged 8 commits into
python:mainfrom
picnixz:feat/ubsan/explicit-conversions

Conversation

picnixz commented Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This is typically useful when one needs to find if a cast is needed or not.

bedevere-app Bot mentioned this pull request Apr 11, 2025
Closed
picnixz changed the title gh-132097: use explicit macro for semantically casting function pointers gh-132097: use a macro for semantically casting function pointers Apr 11, 2025
vstinner reviewed Apr 15, 2025
View reviewed changes
Comment thread Include/methodobject.h Outdated
Comment thread Include/pyport.h
picnixz and others added 3 commits April 18, 2025 10:17
Update Include/methodobject.h
efa7bdc 
Co-authored-by: Victor Stinner <vstinner@python.org>
address review
4bcff7f
improve wording
398e139
picnixz marked this pull request as ready for review April 18, 2025 08:26
picnixz requested a review from markshannon as a code owner April 18, 2025 08:26

picnixz commented Apr 18, 2025

Copy link
Copy Markdown
Member Author

!buildbot EMScripten

bedevere-bot commented Apr 18, 2025

Copy link
Copy Markdown

The regex 'EMScripten' did not match any buildbot builder. Is the requested builder in the list of stable builders?

vstinner approved these changes Apr 18, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Include/pyport.h
Update Include/pyport.h
8f567fa 
Co-authored-by: Victor Stinner <vstinner@python.org>

picnixz commented Apr 18, 2025

Copy link
Copy Markdown
Member Author

Hum, ideally I wanted to be sure that this change won't be bad for EMScripten but hopefully it won't.

@hoodmane Can you confirm that this won't be breaking EMScripten builds? (and do we have a build bot for it?)

picnixz self-assigned this Apr 18, 2025

hoodmane commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

It looks fine to me. No build bot still, we have to merge #132092 first.

Thanks for the ping @picnixz !

picnixz merged commit 3793526 into python:main Apr 18, 2025
picnixz deleted the feat/ubsan/explicit-conversions branch April 18, 2025 10:24
picnixz mentioned this pull request Apr 20, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

picnixz

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL