FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132426: `get_annotate_function` vs. mapping namespaces by eliegoudout · Pull Request #132427 · python/cpython · GitHub

/ cpython Public

gh-132426: get_annotate_function vs. mapping namespaces - #132427

Closed
eliegoudout wants to merge 2 commits into
python:mainfrom
eliegoudout:132426-ns-mapping
ConversationCommits (2)ChecksFiles changed
Closed

gh-132426: get_annotate_function vs. mapping namespaces#132427
eliegoudout wants to merge 2 commits into
python:mainfrom
eliegoudout:132426-ns-mapping

Conversation

eliegoudout commented Apr 12, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

fix: ns can be mapping (closes python#132426)
93afac8 
Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>

python-cla-bot Bot commented Apr 12, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented Apr 12, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

picnixz changed the title fix annotationlib: namespace can be mapping (closes #132426) gh-132426: get_annotate_function should allow mapping-like objects Apr 12, 2025
bedevere-app Bot mentioned this pull request Apr 12, 2025
Closed

eliegoudout commented Apr 12, 2025

Copy link
Copy Markdown
Author

I convert back to draft because of this.

eliegoudout marked this pull request as draft April 12, 2025 08:58
eliegoudout changed the title gh-132426: get_annotate_function should allow mapping-like objects gh-132426: get_annotate_function vs. mapping namespaces Apr 12, 2025
picnixz reviewed Apr 12, 2025
View reviewed changes
Comment thread Lib/annotationlib.py Outdated
Mapping from collections.abc, local
a4ad2c6 
Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>

bedevere-app Bot commented Apr 12, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

JelleZijlstra commented May 4, 2025

Copy link
Copy Markdown
Member

Closing in favor of #132490

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

annotationlib: namespace can be non-dict

3 participants

Back | FazBrowse Home | New Git URL