FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-130655: Add a test for big-endian MO files in `gettext` by tomasr8 · Pull Request #132469 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-130655: Add a test for big-endian MO files in gettext - #132469

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
tomasr8:gettext-bigendian
May 1, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-130655: Add a test for big-endian MO files in gettext#132469
serhiy-storchaka merged 1 commit into
python:mainfrom
tomasr8:gettext-bigendian

Conversation

tomasr8 commented Apr 13, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

MO files can be stored either in little or big-endian format. Which is which is dictated by the file header.
All our test MO files are currently little-endian. We should have at least one test with big-endian as well.

bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 13, 2025
bedevere-app Bot mentioned this pull request Apr 13, 2025
Open
StanFromIreland approved these changes Apr 13, 2025
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

serhiy-storchaka approved these changes May 1, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Comment thread Lib/test/test_gettext.py
]))


GNU_MO_DATA_BIG_ENDIAN = base64.b64encode(bytes([

serhiy-storchaka May 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is weird to use b64encode here, and then decode it back. In future we may use bytes literals.

tomasr8 May 1, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Noted, thanks for the review!

serhiy-storchaka merged commit 474f296 into python:main May 1, 2025

miss-islington-app Bot commented May 1, 2025

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 1, 2025
pythongh-130655: Add a test for big-endian MO files in gettext (pytho…
afad0f2 
…nGH-132469)

(cherry picked from commit 474f296)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>

bedevere-app Bot commented May 1, 2025

Copy link
Copy Markdown

GH-133248 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 1, 2025
serhiy-storchaka pushed a commit that referenced this pull request May 1, 2025
[3.13] gh-130655: Add a test for big-endian MO files in gettext (GH-1…
90c786e 
…32469) (GH-133248)

(cherry picked from commit 474f296)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
tomasr8 deleted the gettext-bigendian branch May 1, 2025 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL