gh-132099: Harmonize Bluetooth address handling - #132486
Conversation
Sorry, something went wrong.
|
Since BTPROTO_HCI support on FreeBSD and all protocols on other BSD did not work just days ago, it is safe to do changes which otherwise could be considered breaking (changing the type of accepting or returning address). BTPROTO_SCO was the only protocol that worked (only on Linux) with bytes addresses in older versions. Now it accepts both str and bytes. |
Sorry, something went wrong.
Now all protocols always accept the Bluetooth address as string and getsockname() always returns the Bluetooth address as string. * BTPROTO_SCO now accepts not only bytes, but str. * BTPROTO_SCO now checks address for embedded null. * On *BSD, BTPROTO_HCI now accepts str instead of bytes. * On FreeBSD, getsockname() for BTPROTO_HCI now returns str instead of bytes. * On NetBSD and DragonFly BDS, BTPROTO_HCI now checks address for embedded null.
|
🤖 New build scheduled with the buildbot fleet by @gpshead for commit 5552a33 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132486%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
|
I tested on NetBSD and FreeBSD. Unfortunately, on FreeBSD all tests are skipped, so we can only hope that the code is correct. |
Sorry, something went wrong.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 1fc1df8dcc7a853b0649bc8df37cd07cbd2b6230 3.13 |
Sorry, something went wrong.
…H-132486) Now all protocols always accept the Bluetooth address as string and getsockname() always returns the Bluetooth address as string. * BTPROTO_SCO now accepts not only bytes, but str. * BTPROTO_SCO now checks address for embedded null. * On *BSD, BTPROTO_HCI now accepts str instead of bytes. * On FreeBSD, getsockname() for BTPROTO_HCI now returns str instead of bytes. * On NetBSD and DragonFly BDS, BTPROTO_HCI now checks address for embedded null. (cherry picked from commit 1fc1df8) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-132497 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…H-132497) Now all protocols always accept the Bluetooth address as string and getsockname() always returns the Bluetooth address as string. * BTPROTO_SCO now accepts not only bytes, but str. * BTPROTO_SCO now checks address for embedded null. * On *BSD, BTPROTO_HCI now accepts str instead of bytes. * On FreeBSD, getsockname() for BTPROTO_HCI now returns str instead of bytes. * On NetBSD and DragonFly BSD, BTPROTO_HCI now checks address for embedded null. (cherry picked from commit 1fc1df8)
Now all protocols always accept the Bluetooth address as string and getsockname() always returns the Bluetooth address as string.
📚 Documentation preview 📚: https://cpython-previews--132486.org.readthedocs.build/