gh-131178: Add tests for http.server command-line interface by ggqlq · Pull Request #132540 · python/cpython · GitHub

#131178

Issue: Add tests for command-line interface #131178

All commit authors signed the Contributor License Agreement.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

I haven't read everything carefully yet, but this is what catches my eye first

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Thank you all!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel ASAN NoGIL 3.x (tier-1) has failed when building commit 605022a.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1366/builds/4325) and take a look at the build logs.
Check if the failure is related to this commit (605022a) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1366/builds/4325

Failed tests:

test_httpservers

Failed subtests:

test_https_client - test.test_httpservers.CommandLineRunTimeTestCase.test_https_client
test_http_client - test.test_httpservers.CommandLineRunTimeTestCase.test_http_client

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_httpservers.py", line 1520, in test_http_client
    res = self.fetch_file(f'http://{bind}:{port}/{self.served_file_name}')
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_httpservers.py", line 1476, in fetch_file
    context = ssl.create_default_context()
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'create_default_context'


Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_httpservers.py", line 1533, in test_https_client
    self.assertTrue(self.wait_for_server(proc, 'https', port, bind))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true

@ggqlq can you add a skipIf if ssl is None? TiA

@ggqlq can you add a skipIf if ssl is None? TiA

I open a new PR #134224 @picnixz

…ython#132540)

Add tests for http.server command-line interface

79db2f2

bedevere-app Bot added the awaiting review label Apr 15, 2025

Merge branch 'python:main' into main

a5e5220

ggqlq added 2 commits April 15, 2025 12:52

add news

2b589bf

add news

e11f8fe

ggqlq changed the title Add tests for http.server command-line interface gh-131178: Add tests for http.server command-line interface Apr 15, 2025

bedevere-app Bot mentioned this pull request Apr 15, 2025

Add tests for command-line interface #131178

Open

9 tasks

lint

4e008fd

donbarbos reviewed Apr 15, 2025

View reviewed changes

Comment thread Lib/http/server.py Outdated

donbarbos reviewed Apr 15, 2025

View reviewed changes

Comment thread Lib/test/test_httpservers.py Outdated

move a new class into test

ad76ab1

ggqlq requested a review from donbarbos April 16, 2025 08:32

donbarbos suggested changes Apr 16, 2025

View reviewed changes

bedevere-app Bot added awaiting core review and removed awaiting review labels Apr 16, 2025

donbarbos reviewed Apr 16, 2025

View reviewed changes

Comment thread Lib/test/test_httpservers.py

donbarbos reviewed Apr 16, 2025

View reviewed changes

Comment thread Lib/test/test_httpservers.py Outdated

ggqlq and others added 9 commits April 16, 2025 21:31

Update Lib/http/server.py

5e563d3

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

Update Lib/http/server.py

86b856e

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

Update Lib/http/server.py

4d5c2b5

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

Update Lib/http/server.py

574d6be

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

Update Lib/http/server.py

c1f3358

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

Update Lib/http/server.py

01d5fb8

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

Update Lib/http/server.py

540700f

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

Update Lib/test/test_httpservers.py

1bdb0ec

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

Update Lib/test/test_httpservers.py

38aea9e

Co-authored-by: Semyon Moroz <donbarbos@proton.me>

donbarbos reviewed Apr 16, 2025

View reviewed changes

Comment thread Lib/test/test_httpservers.py Outdated

picnixz reviewed May 19, 2025

View reviewed changes

ggqlq and others added 10 commits May 19, 2025 19:32

Update Lib/test/test_httpservers.py

6beb7f1

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_httpservers.py

4c25dcd

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_httpservers.py

d67ee16

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_httpservers.py

d5914dc

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_httpservers.py

4d0154e

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_httpservers.py

2ba7001

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_httpservers.py

0c37216

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_httpservers.py

6938dd9

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/test/test_httpservers.py

59be989

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

rename random_... as served_... in the CommandLineRunTimeTestCase class

7a8d6f1

picnixz reviewed May 19, 2025

View reviewed changes

Comment thread Lib/test/test_httpservers.py

Update Lib/test/test_httpservers.py

921739c

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz reviewed May 19, 2025

View reviewed changes

Comment thread Lib/test/test_httpservers.py Outdated

Update Lib/test/test_httpservers.py

6d9981f

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz approved these changes May 19, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels May 19, 2025

picnixz reviewed May 19, 2025

View reviewed changes

Comment thread Lib/test/test_httpservers.py Outdated

Update Lib/test/test_httpservers.py

1d42f2c

picnixz enabled auto-merge (squash) May 19, 2025 11:47

picnixz merged commit 605022a into python:main May 19, 2025

bedevere-app Bot removed the awaiting merge label May 19, 2025

ggqlq mentioned this pull request May 23, 2025

gh-131178: add E2E mockless tests for http.server command-line interface #134279

Merged

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025

pythongh-131178 : Add tests for http.server command-line interface (p…

a595c76

…ython#132540)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025

pythongh-131178 : Add tests for http.server command-line interface (p…

d40a40d

…ython#132540)

gh-131178: Add tests for http.server command-line interface by ggqlq · Pull Request #132540 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-131178: Add tests for http.server command-line interface - #132540

gh-131178: Add tests for http.server command-line interface#132540picnixz merged 79 commits intopython:mainpython/cpython:mainfrom ggqlq:mainggqlq/cpython:mainCopy head branch name to clipboard

Conversation

ggqlq commented Apr 15, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

python-cla-bot Bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app Bot commented Apr 15, 2025

Uh oh!

bedevere-app Bot commented Apr 15, 2025

Uh oh!

Uh oh!

Uh oh!

donbarbos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ggqlq commented May 19, 2025

Uh oh!

bedevere-bot commented May 19, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

picnixz commented May 19, 2025

Uh oh!

ggqlq commented May 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-131178: Add tests for http.server command-line interface#132540
picnixz merged 79 commits into
python:mainfrom
ggqlq:main

ggqlq commented Apr 15, 2025 •
edited by bedevere-app Bot
Loading

python-cla-bot Bot commented Apr 15, 2025 •
edited
Loading