FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-121468: Support async breakpoint in pdb by gaogaotiantian · Pull Request #132576 · python/cpython · GitHub

/ cpython Public

gh-121468: Support async breakpoint in pdb - #132576

Merged
gaogaotiantian merged 13 commits into
python:mainfrom
gaogaotiantian:support-async-breakpoint
Apr 29, 2025
ConversationCommits (13)ChecksFiles changed
Merged

gh-121468: Support async breakpoint in pdb#132576
gaogaotiantian merged 13 commits into
python:mainfrom
gaogaotiantian:support-async-breakpoint

Conversation

gaogaotiantian commented Apr 16, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

I finally figured out how to support await in pdb without too much hack - we can make the breakpoint itself an awaitable, and everything is simply integrated into the system!

This PR introduced a new function pdb.set_trace_async which the users should await, and with that function, the users can do their awaits in th debugger!

📚 Documentation preview 📚: https://cpython-previews--132576.org.readthedocs.build/

bedevere-app Bot mentioned this pull request Apr 16, 2025
Open
gaogaotiantian marked this pull request as ready for review April 16, 2025 23:44

gaogaotiantian commented Apr 21, 2025

Copy link
Copy Markdown
Member Author

Hi @iritkatriel , do you think this needs to be reviewed by asyncio expert?

iritkatriel commented Apr 21, 2025

Copy link
Copy Markdown
Member

Yes, ideally.

gaogaotiantian commented Apr 22, 2025

Copy link
Copy Markdown
Member Author

@kumaraditya303 I hope I can have this in 3.14 because it's a demanding feature. Could you take a look at it and see if it's a reasonable approach? Thanks!

kumaraditya303 reviewed Apr 22, 2025
View reviewed changes
Comment thread Lib/test/test_pdb.py
graingert-coef reviewed Apr 22, 2025
View reviewed changes
Comment thread Lib/pdb.py Outdated
graingert reviewed Apr 22, 2025
View reviewed changes
Comment thread Lib/pdb.py Outdated
and e.msg == "'await' outside function"
):
try:
self._exec_await(buffer, globals, locals)

graingert Apr 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this should be run without the exception from line 891 in the context

gaogaotiantian Apr 22, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I restructured the code as we know whether it is an await code during compile. The nice side effect is that we don't need to execute the code under the exception context.

taegyunkim commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

How about adding these direct links to what you added in the docs
https://cpython-previews--132576.org.readthedocs.build/en/132576/library/pdb.html#pdb.set_trace_async
https://cpython-previews--132576.org.readthedocs.build/en/132576/whatsnew/3.14.html#pdb

gaogaotiantian commented Apr 22, 2025

Copy link
Copy Markdown
Member Author

What do you mean? The link is already in whatsnew entry.

kumaraditya303 reviewed Apr 25, 2025
View reviewed changes
Comment thread Lib/test/test_pdb.py

gaogaotiantian commented Apr 25, 2025

Copy link
Copy Markdown
Member Author

@iritkatriel do you have any other concerns about this PR?

auvipy approved these changes Apr 28, 2025
View reviewed changes

auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks good

gaogaotiantian commented Apr 29, 2025

Copy link
Copy Markdown
Member Author

Hi @iritkatriel , if you don't have any objections I'll merge this in a day or so :)

iritkatriel commented Apr 29, 2025

Copy link
Copy Markdown
Member

Hi @iritkatriel , if you don't have any objections I'll merge this in a day or so :)

Go for it. @kumaraditya303 has approved.

gaogaotiantian merged commit caee16f into python:main Apr 29, 2025
gaogaotiantian deleted the support-async-breakpoint branch April 29, 2025 16:28
5j9 mentioned this pull request Dec 2, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

graingert graingert left review comments
kumaraditya303 kumaraditya303 approved these changes
iritkatriel Awaiting requested review from iritkatriel
+2 more reviewers
graingert-coef graingert-coef left review comments
auvipy auvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL