FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "gh-128384: Use a context variable for warnings.catch_warnings (gh-130010) by hugovk · Pull Request #132601 · python/cpython · GitHub

/ cpython Public

Revert "gh-128384: Use a context variable for warnings.catch_warnings (gh-130010) - #132601

Closed
hugovk wants to merge 1 commit into
python:mainfrom
hugovk:3.14-revert-d687900
ConversationCommits (1)ChecksFiles changed
Closed

Revert "gh-128384: Use a context variable for warnings.catch_warnings (gh-130010)#132601
hugovk wants to merge 1 commit into
python:mainfrom
hugovk:3.14-revert-d687900

Conversation

hugovk commented Apr 16, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This reverts commit d687900.

Draft to test if revert fixes buildbots.

📚 Documentation preview 📚: https://cpython-previews--132601.org.readthedocs.build/

bedevere-app Bot mentioned this pull request Apr 16, 2025
Closed

hugovk commented Apr 16, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 CentOS9 NoGIL Refleaks

bedevere-bot commented Apr 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 32104a3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132601%2Fmerge

The command will test the builders whose names match following regular expression: AMD64 CentOS9 NoGIL Refleaks

The builders matched are:

  • AMD64 CentOS9 NoGIL Refleaks PR

hugovk commented Apr 16, 2025

Copy link
Copy Markdown
Member Author

!buildbot ARM64 MacOS M1 Refleaks NoGIL

bedevere-bot commented Apr 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 32104a3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132601%2Fmerge

The command will test the builders whose names match following regular expression: ARM64 MacOS M1 Refleaks NoGIL

The builders matched are:

  • ARM64 MacOS M1 Refleaks NoGIL PR

hugovk commented Apr 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

The builders matched are:

  • AMD64 CentOS9 NoGIL Refleaks PR

This one passed: https://buildbot.python.org/all/#/builders/1606/builds/299

The other is still pending.

hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2025

bedevere-bot commented Apr 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 32104a3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132601%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2025

hugovk commented Apr 16, 2025

Copy link
Copy Markdown
Member Author

The other is still pending.

Also passed: https://buildbot.python.org/#/builders/1367/builds/554

hugovk mentioned this pull request Apr 16, 2025
Merged

nascheme commented Apr 16, 2025

Copy link
Copy Markdown
Member

Please wait to see if GH-132611 fixes the problem before applying this revert.

nascheme commented Apr 16, 2025

Copy link
Copy Markdown
Member

Please wait to see if GH-132611 fixes the problem before applying this revert.

It seems that GH-132611 has fixed this problem. It was the "refleaks" option that was triggering the issue because it runs the same tests multiple times.

hugovk commented Apr 17, 2025

Copy link
Copy Markdown
Member Author

Great, thank you very much!

hugovk closed this Apr 17, 2025
hugovk deleted the 3.14-revert-d687900 branch April 17, 2025 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner
FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner
1st1 Awaiting requested review from 1st1 1st1 will be requested when the pull request is marked ready for review 1st1 is a code owner
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner
corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL