gh-118761: Add helper to ensure that lazy imports are actually lazy - #132614
Merged
JelleZijlstra merged 2 commits intoApr 17, 2025
Merged
gh-118761: Add helper to ensure that lazy imports are actually lazy#132614JelleZijlstra merged 2 commits into
JelleZijlstra merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…lazy This ensures that if we jump through some hoops to make sure something is imported lazily, we don't regress on importing it. I recently already accidentally made typing import warnings and annotationlib eagerly.
JelleZijlstra
requested review from
AlexWaygood,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
April 16, 2025 20:43
JelleZijlstra
commented
Apr 16, 2025
Comment thread
Lib/test/test_typing.py
| "inspect", | ||
| "re", | ||
| "contextlib", | ||
| # "annotationlib", # TODO |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
#132596 will fix this
Sorry, something went wrong.
AA-Turner
approved these changes
Apr 17, 2025
AA-Turner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good idea!
Sorry, something went wrong.
Comment thread
Lib/test/support/import_helper.py
Comment thread
Lib/test/support/import_helper.py
Outdated
Comment thread
Lib/test/support/import_helper.py
Outdated
Comment thread
Lib/test/test_annotationlib.py
Outdated
Comment thread
Lib/test/test_typing.py
Outdated
Comment thread
Lib/test/test_typing.py
Outdated
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that if we jump through some hoops to make sure something is imported
lazily, we don't regress on importing it.
I recently already accidentally made typing import warnings and annotationlib eagerly.