gh-100239: specialize BINARY_OP/SUBSCR for list-slice - #132626
Merged
iritkatriel merged 9 commits intoMay 1, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
list_subscript/_PyList_Subscript is the general subscript function for lists. I think we want to use a more specialized function that only works for slices. i.e this code: https://github.com/python/cpython/blob/main/Objects/listobject.c#L3614-L3618 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The stats diff show a 50x increase in "subscr tuple slice" as a cause of specialization failure. Any idea why that might be? I can't see any reason for it. |
Sorry, something went wrong.
markshannon
approved these changes
Apr 29, 2025
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarks (stats better, time unchanged):
https://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20250416-3.14.0a7%2B-c52d9d2/bm-20250416-azure-x86_64-iritkatriel-list_subscr-3.14.0a7%2B-c52d9d2-pystats.md