FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132657: Avoid locking in frozenset.__contains__ by eendebakpt · Pull Request #132659 · python/cpython · GitHub

/ cpython Public

gh-132657: Avoid locking in frozenset.__contains__ - #132659

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
eendebakpt:frozenset_contains
Apr 18, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-132657: Avoid locking in frozenset.__contains__#132659
kumaraditya303 merged 2 commits into
python:mainfrom
eendebakpt:frozenset_contains

Conversation

eendebakpt commented Apr 17, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

eendebakpt requested a review from rhettinger as a code owner April 17, 2025 19:36
bedevere-app Bot mentioned this pull request Apr 17, 2025
Closed

rhettinger commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

To my eyes, the new code looks identical to the existing set___contains___impl.

eendebakpt commented Apr 17, 2025

Copy link
Copy Markdown
Contributor Author

Almost identical, except that the set___contains___impl has an extra line @critical_section. This results in a Py_BEGIN_CRITICAL_SECTION in the clinic generated code.

kumaraditya303 merged commit e77d678 into python:main Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

colesbury colesbury approved these changes
rhettinger rhettinger approved these changes
kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL