FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132661: Implement PEP 750 by lysnikolaou · Pull Request #132662 · python/cpython · GitHub

/ cpython Public

gh-132661: Implement PEP 750 - #132662

Merged
lysnikolaou merged 104 commits into
python:mainfrom
lysnikolaou:tstrings
Apr 30, 2025
ConversationCommits (104)ChecksFiles changed
Merged

gh-132661: Implement PEP 750#132662
lysnikolaou merged 104 commits into
python:mainfrom
lysnikolaou:tstrings

Conversation

lysnikolaou commented Apr 17, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

PEP 750 implementation! 🎉

Let's make sure as many people as possible take a look at this, since it's touching many areas that I've not worked on before.

📚 Documentation preview 📚: https://cpython-previews--132662.org.readthedocs.build/

lysnikolaou and others added 30 commits October 18, 2024 17:41
Implement next version of PEP 750
9248287 
Still buggy
First fixes; conv and format_spec still not working
450d771
Change BUILD_INTERPOLATION opcode to simplify
a095a9b
Add templatelib module & clean-up types/objects etc.
499d70c
Support explicit concatenation of template and str
f742d45
Avoid folding one node template into its content
0dda3f9
Implement __eq__ for template and interpolation
17014e7
Fix debug specifier segfault
94371bd
Add __match_args__ to Interpolation
99184cc
Fix syntax error prefix in t-strings
4e89c87
Fix test_dis
6bfb095
Fix test_fstring
560e957
Fix test_embed
4d172c2
Implement interleaving, hash functions and *args __init__
c9362e3
Use Argument Clinic for interpolation_new
d2bd673
Revert to using different grammar rules for tstring due to format_spec
7ae1b60
Fix code generation for when there's many values in tstring
5e7304f
Remove duplicate parens from template repr
c8f22f0
Fix conversion converter for interpolation __new__
b0dbe27
Merge branch 'main' into tstrings
b07c419
Fix test_embed and test_dis -- again
3e84771
Implement implicit concatenation with TemplateStr
9380ab9
Merge branch 'main' into tstrings
22f9dc6
Implement new specification of template type
f207637
Replace nb_add with sq_concat
29b1386
Correctly implement str + tstring
aad5d67
Make changes requested by Steering Council (#57)
77822be 
* Rename expr to expression, conv to conversion
* Move templatelib under string lib
* Add strings lib to LIBSUBDIRS
* Update type of Template/TemplateIter/Interpolation
Merge branch 'main' into tstrings
f3ba0fe
Remove unnecessary _Py_TPFLAGS_MATCH_SELF from Template type (#60)
422a515
Fix memory leak in template concat error handling (#59)
bb7359a 
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

sobolevn commented Apr 28, 2025

Copy link
Copy Markdown
Member

Oh, I messed up, sorry. I clicked "merge main", but it was a long process :(

lysnikolaou commented Apr 28, 2025

Copy link
Copy Markdown
Member Author

Oops, I was too late. 😆

picnixz approved these changes Apr 28, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One question and LGTM.

Comment thread Objects/interpolationobject.c Outdated
markshannon requested changes Apr 29, 2025
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not convinced about adding string/templatelib.py instead of adding the new types to types.
Either way, the C module is unnecessary.

Comment thread Modules/_templatelibmodule.c Outdated
Comment thread Lib/string/templatelib.py
Comment thread Lib/string/templatelib.py Outdated

bedevere-app Bot commented Apr 29, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

lysnikolaou commented Apr 29, 2025

Copy link
Copy Markdown
Member Author

@markshannon Thanks for the review! I've removed the _templatelib extension.

Regarding the types vs string.templatelib discussion, I don't have a strong opinion either way, but it feels that it's too late for it to be reopened. The SC made their decision and I think we should go with it. We're a week away from the beta freeze and I'd like to get this PR in.

sobolevn commented Apr 29, 2025

Copy link
Copy Markdown
Member

In my humble opinion we should not add to types what we can add to some other semantically named module.

lysnikolaou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2025

bedevere-bot commented Apr 29, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @lysnikolaou for commit 0b1aef9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132662%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2025

markshannon commented Apr 29, 2025

Copy link
Copy Markdown
Member

@markshannon Thanks for the review! I've removed the _templatelib extension.

Regarding the types vs string.templatelib discussion, I don't have a strong opinion either way, but it feels that it's too late for it to be reopened. The SC made their decision and I think we should go with it. We're a week away from the beta freeze and I'd like to get this PR in.

I'm fine with you merging this now. It is only a small change to move the code to types.py in another PR if that's what we decide we want.

markshannon self-requested a review April 29, 2025 17:18
dylwil3 reviewed Apr 29, 2025
View reviewed changes
Comment thread Doc/library/token.rst Outdated
lysnikolaou merged commit 6020260 into python:main Apr 30, 2025
dvarrazzo mentioned this pull request May 1, 2025
Closed
tconley1428 mentioned this pull request Oct 16, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments
StanFromIreland StanFromIreland left review comments
picnixz picnixz approved these changes
markshannon markshannon approved these changes
AA-Turner AA-Turner approved these changes
pablogsal pablogsal approved these changes
brandtbucher brandtbucher approved these changes
ZeroIntensity ZeroIntensity approved these changes
sobolevn sobolevn approved these changes
Eclips4 Eclips4 approved these changes
hugovk hugovk approved these changes
isidentical Awaiting requested review from isidentical isidentical is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10
AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
+2 more reviewers
dylwil3 dylwil3 left review comments
vasily-v-ryabov vasily-v-ryabov left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL