FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132542: Set native thread ID after fork by noamcohen97 · Pull Request #132701 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-132542: Set native thread ID after fork - #132701

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
noamcohen97:fork-tid
May 20, 2025
ConversationCommits (5)ChecksFiles changed
Merged

gh-132542: Set native thread ID after fork#132701
serhiy-storchaka merged 5 commits into
python:mainfrom
noamcohen97:fork-tid

Conversation

noamcohen97 commented Apr 18, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Since most of Python's runtime state, including thread-related data, is only consistent after PyOS_AfterFork_Child() is called, updating native_id in the after_fork handler ensures correctness and aligns with Python’s existing fork-handling mechanisms.

bedevere-app Bot mentioned this pull request Apr 18, 2025
Closed
ZeroIntensity reviewed Apr 19, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Needs a blurb entry.

Comment thread Lib/test/test_threading.py Outdated
ZeroIntensity added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 19, 2025

bedevere-bot commented Apr 19, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 6ebd095 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132701%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 19, 2025
ZeroIntensity approved these changes Apr 20, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ZeroIntensity added the needs backport to 3.13 only security fixes label Apr 20, 2025
gpshead reviewed Apr 27, 2025
View reviewed changes
Comment thread Lib/test/test_threading.py Outdated
serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
noamcohen97 requested a review from gpshead May 20, 2025 15:58
serhiy-storchaka approved these changes May 20, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍👍

serhiy-storchaka enabled auto-merge (squash) May 20, 2025 16:15
serhiy-storchaka merged commit 6b73502 into python:main May 20, 2025

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @noamcohen97 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
pythongh-132542: Set native thread ID after fork (pythonGH-132701)
2b4359b 
(cherry picked from commit 6b73502)

Co-authored-by: Noam Cohen <noam@noam.me>

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Sorry, @noamcohen97 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6b735023132a4ac9dc5b849d982104eeb1e8bdad 3.13

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134356 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134361 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2025
serhiy-storchaka pushed a commit that referenced this pull request May 20, 2025
[3.14] gh-132542: Set native thread ID after fork (GH-132701) (GH-134356
8e8d5c9 
)

(cherry picked from commit 6b73502)

Co-authored-by: Noam Cohen <noam@noam.me>
serhiy-storchaka pushed a commit that referenced this pull request May 20, 2025
[3.13] gh-132542: Set native thread ID after fork (GH-132701) (GH-134361
aebbbaf 
)

(cherry picked from commit 6b73502)
noamcohen97 deleted the fork-tid branch May 20, 2025 17:31

kulikjak commented May 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi, the newly added test fails on systems without native_id:

Traceback (most recent call last):
  File "<string>", line 6, in <module>
    parent_thread_native_id = threading.current_thread().native_id
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: '_MainThread' object has no attribute 'native_id'

(while Lib/threading.py does check for its existence, the test does not)

noamcohen97 commented May 21, 2025

Copy link
Copy Markdown
Contributor Author

@kulikjak Thank you for noticing. I apologize for that.
I have created #134408 to address the issue.

@serhiy-storchaka Can you please help with merging the fix?

kulikjak commented May 21, 2025

Copy link
Copy Markdown
Contributor

No worries, thanks for the fix!

lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
pythongh-132542: Set native thread ID after fork (pythonGH-132701)
1c559d8
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-132542: Set native thread ID after fork (pythonGH-132701)
4e8fbaa
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-132542: Set native thread ID after fork (pythonGH-132701)
1a845b7
serhiy-storchaka removed their assignment Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
ZeroIntensity ZeroIntensity approved these changes
gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL