FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127081: lock non-re-entrant `*pwent` calls by duaneg · Pull Request #132748 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-127081: lock non-re-entrant *pwent calls - #132748

Merged
kumaraditya303 merged 6 commits into
python:mainfrom
duaneg:gh-127081-pwd
May 22, 2025
ConversationCommits (6)ChecksFiles changed
Merged

gh-127081: lock non-re-entrant *pwent calls#132748
kumaraditya303 merged 6 commits into
python:mainfrom
duaneg:gh-127081-pwd

Conversation

duaneg commented Apr 20, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The libc setpwent, getpwent, and endpwent functions are not thread-safe. Protect them with mutexs in free-threading builds.

pythongh-127081: lock non-re-entrant *pwent calls
78c9cde 
The libc setpwent, getpwent, and endpwent functions are not thread-safe.
Protect them with mutexs in free-threading builds.
bedevere-app Bot mentioned this pull request Apr 20, 2025
Open
picnixz changed the title gh-127081: lock non-re-entrant *pwent calls gh-127081: lock non-re-entrant *pwent calls Apr 20, 2025
ZeroIntensity reviewed Apr 20, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need a critical section here. Py_CLEAR and Py_DECREF are re-entrant (as in, they can invoke the eval loop), so a mutex is prone to lock-ordering or re-entrancy deadlocks.

ZeroIntensity commented Apr 20, 2025

Copy link
Copy Markdown
Member

Actually, sorry, we need to fix subinterpreter thread-safety here too. We can't do that with a critical section. Could you adjust the mutex to go over solely the libc calls?

picnixz reviewed Apr 20, 2025
View reviewed changes
Comment thread Modules/pwdmodule.c
picnixz reviewed Apr 20, 2025
View reviewed changes
Comment thread Modules/pwdmodule.c Outdated

duaneg commented Apr 20, 2025

Copy link
Copy Markdown
Contributor Author

Py_CLEAR and Py_DECREF are re-entrant...Could you adjust the mutex to go over solely the libc calls?

Hmm, yeah, good point. I guess we can just defer the decrefs until exit.

picnixz reviewed Apr 26, 2025
View reviewed changes
Comment thread Modules/pwdmodule.c Outdated
Comment thread Modules/pwdmodule.c Outdated
Comment thread Modules/pwdmodule.c Outdated
kumaraditya303 self-requested a review May 21, 2025 16:51
kumaraditya303 reviewed May 21, 2025
View reviewed changes
Comment thread Modules/pwdmodule.c
Once the newly created pwent items are successfully added to the list…
7ca6858 
… they are

strongly referenced by that, so we can dec-ref them safely.
kumaraditya303 reviewed May 22, 2025
View reviewed changes
Comment thread Modules/pwdmodule.c Outdated
kumaraditya303 merged commit 458e330 into python:main May 22, 2025
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
pythongh-127081: lock non-re-entrant *pwent calls in free-threading (…
6bc83e4 
…python#132748)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-127081: lock non-re-entrant *pwent calls in free-threading (…
7f99913 
…python#132748)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-127081: lock non-re-entrant *pwent calls in free-threading (…
3718860 
…python#132748)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythongh-127081: lock non-re-entrant *pwent calls in free-threading (…
41aec15 
…python#132748)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
ZeroIntensity ZeroIntensity left review comments
kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL