FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127081: add critical sections to `dbm` objects by duaneg · Pull Request #132749 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-127081: add critical sections to dbm objects - #132749

Merged
corona10 merged 3 commits into
python:mainfrom
duaneg:gh-127081-dbm
May 14, 2025
ConversationCommits (3)ChecksFiles changed
Merged

gh-127081: add critical sections to dbm objects#132749
corona10 merged 3 commits into
python:mainfrom
duaneg:gh-127081-dbm

Conversation

duaneg commented Apr 20, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The dbm_* functions are not thread-safe, naturally. Add critical sections to protect their use.

pythongh-127081: add critical sections to dbm objects
83a05d5 
The dbm_* functions are not thread-safe, naturally. Add critical sections to
protect their use.
bedevere-app Bot mentioned this pull request Apr 20, 2025
Open
picnixz changed the title gh-127081: add critical sections to dbm objects gh-127081: add critical sections to dbm objects Apr 20, 2025
ZeroIntensity reviewed Apr 20, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In general, it's easier to add lock_held variations of functions instead of adding inline critical sections with goto. For example:

static int
dbm_something_lock_held(PyObject *self)
{
    /* ... */
}

static int
dbm_something(PyObject *self)
{
    int result;
    Py_BEGIN_CRITICAL_SECTION(self);
    result = dbm_something_lock_held(self);
    Py_END_CRITICAL_SECTION();
    return result;
}

Would you mind switching over to that pattern here?

duaneg commented Apr 20, 2025

Copy link
Copy Markdown
Contributor Author

In general, it's easier to add lock_held variations of functions instead of adding inline critical sections with goto.... Would you mind switching over to that pattern here?

For sure, that would be much more robust, thanks!

corona10 self-assigned this Apr 23, 2025

corona10 commented May 14, 2025

Copy link
Copy Markdown
Member

Sorry for the delay, I will review during the PyCon sprint.

ZeroIntensity approved these changes May 14, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM as well

corona10 commented May 14, 2025

Copy link
Copy Markdown
Member

Would you like to update clinic again?

corona10 commented May 14, 2025

Copy link
Copy Markdown
Member

Oh it's not relatede to dbms.

corona10 merged commit ffaeb3d into python:main May 14, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-127081: add critical sections to dbm objects (pythongh-132749
f8abf21 
)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-127081: add critical sections to dbm objects (pythongh-132749
e4523b1 
)
yoney mentioned this pull request Sep 8, 2025
Merged
kumaraditya303 added the needs backport to 3.14 bugs and security fixes label Oct 12, 2025

miss-islington-app Bot commented Oct 12, 2025

Copy link
Copy Markdown

Thanks @duaneg for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2025
pythongh-127081: add critical sections to dbm objects (pythongh-132749
ea474a0 
)

(cherry picked from commit ffaeb3d)

Co-authored-by: Duane Griffin <duaneg@dghda.com>

bedevere-app Bot commented Oct 12, 2025

Copy link
Copy Markdown

GH-139996 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 12, 2025
kumaraditya303 pushed a commit that referenced this pull request Oct 12, 2025
[3.14] gh-127081: add critical sections to dbm objects (gh-132749) (#…
07eb67b 
…139996)

gh-127081: add critical sections to `dbm` objects (gh-132749)
(cherry picked from commit ffaeb3d)

Co-authored-by: Duane Griffin <duaneg@dghda.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes
ZeroIntensity ZeroIntensity approved these changes
kumaraditya303 kumaraditya303 approved these changes
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
serhiy-storchaka Awaiting requested review from serhiy-storchaka serhiy-storchaka is a code owner

Assignees

corona10

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL