FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132798: Schedule removal of `PyUnicode_AsDecoded/Encoded` functions for 3.15 by StanFromIreland · Pull Request #132799 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-132798: Schedule removal of PyUnicode_AsDecoded/Encoded functions for 3.15 - #132799

Merged
vstinner merged 5 commits into
python:mainfrom
StanFromIreland:removal-schedule
Apr 25, 2025
ConversationCommits (5)ChecksFiles changed
Merged

gh-132798: Schedule removal of PyUnicode_AsDecoded/Encoded functions for 3.15#132799
vstinner merged 5 commits into
python:mainfrom
StanFromIreland:removal-schedule

Conversation

StanFromIreland commented Apr 22, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 22, 2025
Closed
ZeroIntensity reviewed Apr 22, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These functions are in the limited API. I'm not sure what the procedure is for removing them, but they can't just disappear from the ABI. I think the practice is to remove them from headers when the limited API isn't used. We should probably make note of that somewhere.

vstinner commented Apr 22, 2025

Copy link
Copy Markdown
Member

These functions are in the limited API. I'm not sure what the procedure is for removing them

Mark them as abi_only in Misc/stable_abi.toml, keep their implementation, and use PyAPI_FUNC() in the C file.

See PyUnicode_GetSize() for an existing example.

vstinner approved these changes Apr 22, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner reviewed Apr 22, 2025
View reviewed changes
Comment thread Doc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
Comment thread Doc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
Comment thread Doc/deprecations/c-api-pending-removal-in-3.15.rst Outdated

StanFromIreland commented Apr 25, 2025

Copy link
Copy Markdown
Member Author

Anything else left to do @vstinner ?

vstinner reviewed Apr 25, 2025
View reviewed changes
Comment thread Doc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
Comment thread Doc/deprecations/c-api-pending-removal-in-3.15.rst Outdated
Apply suggestions from code review
0db25d0 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner approved these changes Apr 25, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

cc @serhiy-storchaka @methane

vstinner merged commit f6fb498 into python:main Apr 25, 2025
StanFromIreland deleted the removal-schedule branch April 25, 2025 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity left review comments
vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL