gh-132805 - annotationlib - Fix unions of real types and forward references. - #132806
Closed
DavidCEllis wants to merge 4 commits into
Closed
gh-132805 - annotationlib - Fix unions of real types and forward references.#132806DavidCEllis wants to merge 4 commits into
DavidCEllis wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for #132805
This adds a create_unions parameter to _StringifierDict which - if set to True - creates unions between _Stringifier instances instead of trying to join them with ast methods. This is set to True only for Format.FORWARDREF, the behaviour is unchanged for Format.STRING.