FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132825: Enhance unhashable error messages for dict and set by vstinner · Pull Request #132828 · python/cpython · GitHub

/ cpython Public

gh-132825: Enhance unhashable error messages for dict and set - #132828

Merged
cfbolz merged 2 commits into
python:mainfrom
vstinner:unhashable
Apr 23, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-132825: Enhance unhashable error messages for dict and set#132828
cfbolz merged 2 commits into
python:mainfrom
vstinner:unhashable

Conversation

vstinner commented Apr 23, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 23, 2025
Closed
vstinner changed the title gh-132825: Change unhashable key error messages for dict and set gh-132825: Enhance unhashable error messages for dict and set Apr 23, 2025
cfbolz approved these changes Apr 23, 2025
View reviewed changes

cfbolz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is great thanks for working on this right away, Victor! As @methane pointed out, maybe Cannot -> cannot. We don't have a style guide or anything for exception messages, so maybe it doesn't matter either.

vstinner commented Apr 23, 2025

Copy link
Copy Markdown
Member Author

maybe Cannot -> cannot

Done: I replaced "Cannot ..." with "cannot ...".

rhettinger removed their request for review April 23, 2025 14:46
cfbolz merged commit 426449d into python:main Apr 23, 2025
vstinner deleted the unhashable branch April 23, 2025 15:16

matthiask commented Apr 23, 2025

Copy link
Copy Markdown

Thanks for this improvement! One minor nit: I like wordplays but I'm not sure if the T in unhashTable has been introduced on purpose?

vstinner commented Apr 23, 2025

Copy link
Copy Markdown
Member Author

Thanks for this improvement! One minor nit: I like wordplays but I'm not sure if the T in unhashTable has been introduced on purpose?

It wasn't done on purpose, it's a typo :-( I wrote #132847 to fix the typo.

Feuermurmel mentioned this pull request May 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cfbolz cfbolz approved these changes
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner
methane Awaiting requested review from methane methane is a code owner
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL