gh-127604: Allow faulthandler to dumpC stack on MacOS - #132841
Merged
pablogsal merged 2 commits intoApr 23, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Author
❯ ./python.exe -m test test_faulthandler -v | grep c_stack test_dump_c_stack (test.test_faulthandler.FaultHandlerTests.test_dump_c_stack) ... ok test_dump_c_stack_file (test.test_faulthandler.FaultHandlerTests.test_dump_c_stack_file) ... ok ~/github/python/main gh-127604* 17s ❯ uname -a Darwin HWJ59XLTF9 24.4.0 Darwin Kernel Version 24.4.0: Fri Apr 11 18:33:47 PDT 2025; root:xnu-11417.101.15~117/RELEASE_ARM64_T6000 arm64 |
Sorry, something went wrong.
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
ZeroIntensity
approved these changes
Apr 23, 2025
ZeroIntensity
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I don't have a Mac to test this on, so I'll trust that you've tested this locally. The tests only require that it either spits out <cannot get backtrace> or the actual C backtrace.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
My previous comment was proving exactly that :) |
Sorry, something went wrong.
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.