FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131798: JIT: Split CALL_TUPLE_1 into several uops by tomasr8 · Pull Request #132851 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131798: JIT: Split CALL_TUPLE_1 into several uops - #132851

Merged
brandtbucher merged 6 commits into
python:mainfrom
tomasr8:jit-call-tuple-1
Apr 24, 2025
ConversationCommits (6)ChecksFiles changed
Merged

gh-131798: JIT: Split CALL_TUPLE_1 into several uops#132851
brandtbucher merged 6 commits into
python:mainfrom
tomasr8:jit-call-tuple-1

Conversation

tomasr8 commented Apr 23, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

CALL_TUPLE_1 is equivalent to tuple(...).

Very similar to previous work on splitting up CALL_TYPE_1: #132419
This splits the instruction into a smaller instruction + 2 guards which can be optimized away. This also sets the return type to tuple.

bedevere-app Bot mentioned this pull request Apr 23, 2025
Open
tomasr8 commented Apr 24, 2025
View reviewed changes
Comment thread Python/optimizer_bytecodes.c
Comment on lines 961 to 964

tomasr8 Apr 24, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same optimization as in #132849 (comment)

Comment thread Lib/test/test_capi/test_opt.py

tomasr8 Apr 24, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I needed to use UNPACK_SEQUENCE(_TWO)_TUPLE here since it is currently the only uop that propagates the tuple items to the result.

brandtbucher Apr 24, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice observation. Seems like _BINARY_OP_SUBSCR_TUPLE_INT could be taught how to do this pretty easily for a constant RHS. Want to add that to your queue?

tomasr8 Apr 24, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's already in the queue 😄

brandtbucher merged commit 08e3389 into python:main Apr 24, 2025
tomasr8 deleted the jit-call-tuple-1 branch April 25, 2025 05:55
tomasr8 mentioned this pull request Apr 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher left review comments
Fidget-Spinner Fidget-Spinner approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL