| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
I wasn't aware of _Py_DumpHexadecimal, this works a lot better than the mess of dup and file APIs in #132800. Thanks!
Sorry, something went wrong.
|
This introduced a compiler warning: Python/traceback.c:883:1: warning: ‘dump_pointer’ defined but not used [-Wunused-function]
883 | dump_pointer(int fd, void *ptr)
| ^~~~~~~~~~~~Maybe the function should also be behind an #ifdef? |
Sorry, something went wrong.
I wrote #132897 to fix the warning. On which machine/OS did you see the warning? |
Sorry, something went wrong.
|
Aha, now I can see the warning on the WASI build. The configure script says: checking for backtrace... (cached) no checking for backtrace_symbols... (cached) no |
Sorry, something went wrong.
I saw it on Ubuntu 24.04 |
Sorry, something went wrong.
Ok, good to know. I suppose that you miss backtrace_symbol() function. Likely a missing dependency. On Fedora, the /usr/include/execinfo.h header is provided by the glibc-devel package. Anyway, the warning was fixed by c292f7f. Thanks for the report. |
Sorry, something went wrong.
|
Interesting, I do have the /usr/include/execinfo.h header, but the backtrace_symbol function is missing: extern int backtrace (void **__array, int __size) __nonnull ((1));
extern char **backtrace_symbols (void *const *__array, int __size)
__THROW __nonnull ((1));
extern void backtrace_symbols_fd (void *const *__array, int __size, int __fd)
__THROW __nonnull ((1)); |
Sorry, something went wrong.
|
configure.ac looks for these functions: $ grep backtrace configure.ac -B1
AC_CHECK_HEADERS([execinfo.h link.h dlfcn.h],
[AC_CHECK_FUNCS(backtrace backtrace_symbols dladdr1)])
Sorry, it's backtrace_symbols() with S :-) @ZeroIntensity: By the way, backtrace_symbols test can now removed from configure.ac, it's no longer used, right? |
Sorry, something went wrong.
|
Yup, but I don't know of a system that provides backtrace but not backtrace_symbols. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.