gh-93696: Fixed the breakpoint display error for frozen modules - #132862
Merged
gaogaotiantian merged 3 commits intoApr 24, 2025
Merged
gh-93696: Fixed the breakpoint display error for frozen modules#132862gaogaotiantian merged 3 commits into
gaogaotiantian merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
iritkatriel
reviewed
Apr 24, 2025
Comment thread
Lib/test/test_pdb.py
Outdated
| stdout, _ = self._run_pdb(["gh93696_host.py"], commands_longlist) | ||
| self.assertIn('x = "Sentinel string for gh-93696"', stdout, "Sentinel statement not found") | ||
| self.assertIn('4 B', stdout, "breakpoint not found") | ||
| self.assertIn('-> def func():', stdout, "stack entry not found") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
These two tests look identical as l. Make a loop?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Good point! I used loop for it.
Sorry, something went wrong.
iritkatriel
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#93697 attempted to extract the actual file of a frozen module, but it only did it for list, not longlist or where. With #131638, we can get source code of frozen modules without any extra efforts, so we should remove this piece of code now.
Also, this code introduced a small error - it does not show breakpoints correctly. When we set breakpoints, we use the co_filename (<frozen XXX>) as the key. Breakpoints can't be found if the filename is converted to real file, so the B indicator will not be there.
Some extra tests were added.