FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-63882: Implement some `test_minidom` tests by StanFromIreland · Pull Request #132879 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-63882: Implement some test_minidom tests - #132879

Merged
hugovk merged 6 commits into
python:mainfrom
StanFromIreland:apply-patch
Apr 26, 2025
ConversationCommits (6)ChecksFiles changed
Merged

gh-63882: Implement some test_minidom tests#132879
hugovk merged 6 commits into
python:mainfrom
StanFromIreland:apply-patch

Conversation

StanFromIreland commented Apr 24, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 24, 2025
bedevere-app Bot mentioned this pull request Apr 24, 2025
Closed

hugovk commented Apr 24, 2025

Copy link
Copy Markdown
Member

Please include the original patch author in a Co-authored-by trailer.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

StanFromIreland and others added 2 commits April 24, 2025 16:45
Apply patch
6c5b9b0 
Co-authored-by: Julian Gindi <julian@gindi.io>
Clean up
ec9c382

This comment was marked as resolved.

Sign in to view
hugovk reviewed Apr 25, 2025
View reviewed changes
Comment thread Lib/test/test_minidom.py Outdated
Update Lib/test/test_minidom.py
df9feb8 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
picnixz reviewed Apr 25, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've added some comments concerning unlink but AFAIK, this is only used to break internal references within the DOM itself. Since the objects are either discarded at the end of the function or are small, you might also forget about calling .unlink. OTOH, we can be consistent with the existing tests and always call unlink in an addCleanup instead.

Comment thread Lib/test/test_minidom.py Outdated
Comment thread Lib/test/test_minidom.py Outdated
Comment thread Lib/test/test_minidom.py Outdated
Comment thread Lib/test/test_minidom.py Outdated
Comment thread Lib/test/test_minidom.py
Comment thread Lib/test/test_minidom.py
Comment thread Lib/test/test_minidom.py
StanFromIreland and others added 2 commits April 25, 2025 15:53
Apply suggestions from code review
c3b759c 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Benedikt's suggestions
540a359
hugovk approved these changes Apr 26, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks

picnixz approved these changes Apr 26, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but I have a question.

Comment thread Lib/test/test_minidom.py Outdated
StanFromIreland commented Apr 26, 2025
View reviewed changes
Comment thread Lib/test/test_minidom.py Outdated

StanFromIreland commented Apr 26, 2025

Copy link
Copy Markdown
Member Author

Question has been resolved.

picnixz self-assigned this Apr 26, 2025

picnixz commented Apr 26, 2025

Copy link
Copy Markdown
Member

@hugovk I'll actually let you write the commit message as I don't know how you want the original patch's author to be credited.

picnixz removed their assignment Apr 26, 2025
StanFromIreland mentioned this pull request Apr 26, 2025
Merged
hugovk merged commit ee033d4 into python:main Apr 26, 2025

hugovk commented Apr 26, 2025

Copy link
Copy Markdown
Member

Thanks, just to make sure the Co-authored-by was in the commit description.

hugovk added the needs backport to 3.13 only security fixes label Apr 26, 2025

miss-islington-app Bot commented Apr 26, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2025
pythongh-63882: Implement some test_minidom tests (pythonGH-132879)
0496125 
(cherry picked from commit ee033d4)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Julian Gindi <julian@gindi.io>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Apr 26, 2025

Copy link
Copy Markdown

GH-133029 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 26, 2025
StanFromIreland deleted the apply-patch branch April 26, 2025 20:07

StanFromIreland commented Apr 26, 2025

Copy link
Copy Markdown
Member Author

It should have been auto populated by gh I believe?

hugovk added a commit that referenced this pull request Apr 26, 2025
[3.13] gh-63882: Implement some test_minidom tests (GH-132879) (#13…
fdcaaad 
…3029)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Julian Gindi <julian@gindi.io>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-bot commented Apr 26, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.13 (tier-3) has failed when building commit fdcaaad.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1386/builds/1246) and take a look at the build logs.
  4. Check if the failure is related to this commit (fdcaaad) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1386/builds/1246

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/threading.py", line 1041, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/threading.py", line 992, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

StanFromIreland commented Apr 26, 2025

Copy link
Copy Markdown
Member Author

Unrelated fail.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL