FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132908: Add math.isnormal/issubnormal() functions by skirpichev · Pull Request #132935 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-132908: Add math.isnormal/issubnormal() functions - #132935

Merged
serhiy-storchaka merged 10 commits into
python:mainfrom
skirpichev:isnormal-subnormal/132908
Jun 2, 2025
ConversationCommits (10)ChecksFiles changed
Merged

gh-132908: Add math.isnormal/issubnormal() functions#132935
serhiy-storchaka merged 10 commits into
python:mainfrom
skirpichev:isnormal-subnormal/132908

Conversation

skirpichev commented Apr 25, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 25, 2025
Closed
StanFromIreland reviewed Apr 25, 2025
View reviewed changes
Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2025-04-25-16-06-53.gh-issue-132908.wV5rja.rst Outdated
Comment thread Doc/library/math.rst
skirpichev commented Apr 25, 2025
View reviewed changes
Comment thread Doc/library/math.rst Outdated
skirpichev commented Apr 25, 2025
View reviewed changes
Comment thread Doc/library/math.rst Outdated
Apply suggestions from code review
4eb3669 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
picnixz approved these changes Apr 25, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just some cosmetic nits.

Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated
Comment thread Modules/mathmodule.c Outdated
Comment thread Modules/mathmodule.c
Comment thread Modules/mathmodule.c
Comment thread Modules/mathmodule.c
skirpichev and others added 2 commits April 25, 2025 17:45
Apply suggestions from code review
37b3345 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Apply suggestions from code review
e318087 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz commented Apr 25, 2025

Copy link
Copy Markdown
Member

So, we have some known buildbots issues. I'll wait for it to be solved and then once it's ok for them, I'll merge it.

skirpichev commented Apr 25, 2025

Copy link
Copy Markdown
Member Author

Technically it's very trivial pr, yet I would appreciate a second look from someone.

Maybe we should be more vague and not define in any way normal/subnormal meaning (i.e. not reference sys.float_info). (Or mention this as CPython implementation detail.) E.g. should all Python implementations support subnormals?

StanFromIreland approved these changes Apr 25, 2025
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IMO the docs and implementation are fine, everything is explained well.

skirpichev commented Apr 28, 2025
View reviewed changes

skirpichev left a comment •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe we can replace "floating-point number" with just a "number" (as integers are automatically converted to floats)?

Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated

skirpichev commented Jun 2, 2025

Copy link
Copy Markdown
Member Author

CC @serhiy-storchaka per experts index. See also issue thread.

serhiy-storchaka changed the title gh-132908: add math.normal/subnormal() functions gh-132908: Add math.isnormal/issubnormal() functions Jun 2, 2025
serhiy-storchaka approved these changes Jun 2, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

Comment thread Modules/mathmodule.c Outdated
Comment thread Doc/library/math.rst Outdated
serhiy-storchaka merged commit 5f61cde into python:main Jun 2, 2025
skirpichev deleted the isnormal-subnormal/132908 branch June 2, 2025 10:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes
serhiy-storchaka serhiy-storchaka approved these changes
StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL