FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-91048: Chain some exceptions in _testexternalinspection.c by sergey-miryanov · Pull Request #132970 · python/cpython · GitHub

/ cpython Public

gh-91048: Chain some exceptions in _testexternalinspection.c - #132970

Merged
pablogsal merged 8 commits into
python:mainfrom
sergey-miryanov:fix-test-external-inspection
May 2, 2025
ConversationCommits (8)ChecksFiles changed
Merged

gh-91048: Chain some exceptions in _testexternalinspection.c#132970
pablogsal merged 8 commits into
python:mainfrom
sergey-miryanov:fix-test-external-inspection

Conversation

sergey-miryanov commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Added extra Py_UNREACHABLE calls on unsupported platforms
  2. Remove unused refcnt read
  3. Set result to 0 if fd closing failed
  4. Chain some exceptions to get more info if failed

sergey-miryanov changed the title Chain some exceptions in _testexternalinspection.c gh-91048: Chain some exceptions in _testexternalinspection.c Apr 25, 2025
bedevere-app Bot mentioned this pull request Apr 25, 2025
Closed
picnixz reviewed Apr 25, 2025
View reviewed changes
Comment thread Modules/_testexternalinspection.c Outdated
sergey-miryanov marked this pull request as ready for review April 25, 2025 21:00

sergey-miryanov commented Apr 25, 2025

Copy link
Copy Markdown
Contributor Author

@pablogsal Please take a look.

pablogsal approved these changes May 2, 2025
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

This is a great improvement. Thanks a lot!

pablogsal merged commit bd2ed7c into python:main May 2, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-91048: Chain some exceptions in _testexternalinspection.c (p…
12e7c87 
…ython#132970)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL