gh-132775: Drop PyUnstable_InterpreterState_GetMainModule() - #132978
Merged
ericsnowcurrently merged 2 commits intoApr 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…odule() and _Py_CheckMainModule().
ericsnowcurrently
force-pushed
the
replace-pyUnstable_interpreterstate_get-main-module
branch
from
ed0d690 to
9c9c41c
Compare
April 25, 2025 23:02
ericsnowcurrently
requested review from
brettcannon,
kumaraditya303,
ncoghlan and
warsaw
as code owners
April 25, 2025 23:02
ericsnowcurrently
deleted the
replace-pyUnstable_interpreterstate_get-main-module
branch
April 28, 2025 18:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace it with _Py_GetMainModule(), and add _Py_CheckMainModule(), but in the internal-only C-API. We also add _PyImport_GetModulesRef(), which is the equivalent of _PyImport_GetModules() that incref's while the lock is held.
This is used by a later change related to pickle and handling __main__.
📚 Documentation preview 📚: https://cpython-previews--132978.org.readthedocs.build/