gh-132775: Add _PyCode_ReturnsOnlyNone() - #132981
Merged
ericsnowcurrently merged 5 commits intoApr 29, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I think this name is confusing because a function returning None also returns. |
Sorry, something went wrong.
iritkatriel
reviewed
Apr 28, 2025
Comment thread
Objects/codeobject.c
Outdated
| Py_ssize_t len = Py_SIZE(co); | ||
| for (int i = 0; i < len; i++) { | ||
| _Py_CODEUNIT inst = _Py_GetBaseCodeUnit(co, i); | ||
| if (inst.op.code == RETURN_VALUE) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
In the past we also had RETURN_CONST and we might have something like that in the future, so I think we should make this more robust. Perhaps add a macro in Include/internal/pycore_opcode_utils.h (say IS_RETURN_OPCODE). Also use this new macro in basicblock_returns in flowgraph.c.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
done
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function indicates whether or not the function has a return statement.
This is used by a later change related treating some functions like scripts.