gh-124703: Set return code to 1 when aborting process from pdb - #133013
Merged
gaogaotiantian merged 3 commits intoApr 26, 2025
Merged
gh-124703: Set return code to 1 when aborting process from pdb#133013gaogaotiantian merged 3 commits into
gaogaotiantian merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
iritkatriel
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #124703 (comment) mentioned, it's probably better to set the return code to something other than 0 when we abort the process from pdb. Logically it makes more sense, and the behavior is closer to what was before.