FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-63882: Break down `and` tests in `test_minidom` by StanFromIreland · Pull Request #133026 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-63882: Break down and tests in test_minidom - #133026

Merged
hugovk merged 1 commit into
python:mainfrom
StanFromIreland:minidom-750-up
May 5, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-63882: Break down and tests in test_minidom#133026
hugovk merged 1 commit into
python:mainfrom
StanFromIreland:minidom-750-up

Conversation

StanFromIreland commented Apr 26, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

First part, up to 750 lines. Continues my previous work.

Did these by hand, they should be all right now ;-)

request: @picnixz @hugovk

bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 26, 2025
bedevere-app Bot mentioned this pull request Apr 26, 2025
Closed
picnixz changed the title gh-63882: Use self.assert* in test_minidom gh-63882: Break down and tests in test_minidom Apr 26, 2025
hugovk approved these changes May 5, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks

hugovk added the needs backport to 3.13 only security fixes label May 5, 2025
hugovk enabled auto-merge (squash) May 5, 2025 15:54
hugovk merged commit e294e16 into python:main May 5, 2025

miss-islington-app Bot commented May 5, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2025
pythongh-63882: Break down and tests in test_minidom (pythonGH-13…
906a6d6 
…3026)

(cherry picked from commit e294e16)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app Bot commented May 5, 2025

Copy link
Copy Markdown

GH-133451 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 5, 2025
StanFromIreland deleted the minidom-750-up branch May 5, 2025 16:08
hugovk pushed a commit that referenced this pull request May 5, 2025
[3.13] gh-63882: Break down and tests in test_minidom (GH-133026) (…
d84a762 
…#133451)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-63882: Break down and tests in test_minidom (python#133026)
7677686
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL