gh-131878: Fix input of unicode characters with two or more code points in the REPL on Windows in vt mode - #133030
Closed
chris-eibl wants to merge 5 commits into
Closed
gh-131878: Fix input of unicode characters with two or more code points in the REPL on Windows in vt mode#133030chris-eibl wants to merge 5 commits into
chris-eibl wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
chris-eibl
commented
Apr 26, 2025
Comment thread
Lib/_pyrepl/windows_console.py
| elif self.__vt_support: | ||
| # If virtual terminal is enabled, scanning VT sequences | ||
| self.event_queue.push(rec.Event.KeyEvent.uChar.UnicodeChar) | ||
| for char in raw_key.encode(self.event_queue.encoding, |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I'd love to use PEP-467 iterbytes() here :)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I like this proposal. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Closing since #131901 is merged and backported. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ab8efa7 is the fix on top of the reverted #130805.
49078f3 shows how I'd like to only accept bytes of length=1 in BaseEventQueue.push().
Only the tests used the int code path somewhat non-transparent by using strings which got converted to due to else ord(char) to bytes of length=1 again:
Maybe too much churn, thus just a draft.