FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject by corona10 · Pull Request #133039 · python/cpython · GitHub

/ cpython Public

gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject - #133039

Merged
corona10 merged 4 commits into
python:mainfrom
corona10:kumar-test
Apr 29, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject#133039
corona10 merged 4 commits into
python:mainfrom
corona10:kumar-test

Conversation

corona10 commented Apr 27, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

corona10 changed the title Kumar test gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject Apr 27, 2025
bedevere-app Bot mentioned this pull request Apr 27, 2025
Closed

corona10 commented Apr 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

@kumaraditya303 @colesbury
I continued working on Kumar's PR #132091. In the new change, more states of unicode_modifiable are observed in free-threading builds. So I added a fallback to use resize_copy when unicode_modifiable fails, but I'm not sure if this is the right approach.
But the test failure issues are resolved.

corona10 marked this pull request as ready for review April 27, 2025 10:12
corona10 changed the title gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject Apr 27, 2025
serhiy-storchaka reviewed Apr 28, 2025
View reviewed changes
Comment thread Objects/unicodeobject.c Outdated
Update Objects/unicodeobject.c
2750016 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka approved these changes Apr 28, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

colesbury approved these changes Apr 28, 2025
View reviewed changes

colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I looked into the case that requires resize_copy: We have an io.StringIO, which is used first by one thread and then by a second thread. (It's not used by two threads simultaneously). The io.StringIO has the only reference to a PyUnicodeWriter, which in turn has the only reference to unicode object that is treated as a buffer.

The _PyObject_IsUniquelyReferenced() check is too conservative in this case because the unicode object is owned by a different thread. The unicode object is actually safe to modify, we just can't tell that from _PyObject_IsUniquelyReferenced().

corona10 merged commit 75cbb8d into python:main Apr 29, 2025

miss-islington-app Bot commented Apr 29, 2025

Copy link
Copy Markdown

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 29, 2025
pythongh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject (p…
4f40bf2 
…ythongh-133039)

---------
(cherry picked from commit 75cbb8d)

Co-authored-by: Donghee Na <donghee.na@python.org>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented Apr 29, 2025

Copy link
Copy Markdown

GH-133121 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Apr 29, 2025
corona10 deleted the kumar-test branch April 29, 2025 02:07

bedevere-app Bot commented Apr 29, 2025

Copy link
Copy Markdown

GH-133126 is a backport of this pull request to the 3.13 branch.

corona10 added a commit that referenced this pull request Apr 29, 2025
[3.13] gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject (…
7ffef8d 
…gh-133039) (gh-133126)

* gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject (gh-133039)

---------
(cherry picked from commit 75cbb8d)

Co-authored-by: Donghee Na <donghee.na@python.org>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

* Add _PyObject_IsUniquelyReferenced

---------

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
corona10 mentioned this pull request Apr 29, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

colesbury colesbury approved these changes
serhiy-storchaka serhiy-storchaka approved these changes
kumaraditya303 Awaiting requested review from kumaraditya303

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL