FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-23378: Add an extend action to argparse by isidentical · Pull Request #13305 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-23378: Add an extend action to argparse - #13305

Merged
miss-islington merged 2 commits into
python:masterfrom
isidentical:issue23378
May 21, 2019
ConversationCommits (2)ChecksFiles changed
Merged

bpo-23378: Add an extend action to argparse#13305
miss-islington merged 2 commits into
python:masterfrom
isidentical:issue23378

Conversation

isidentical commented May 14, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Add an extend action to argparse

https://bugs.python.org/issue23378

asottile reviewed May 18, 2019
View reviewed changes

asottile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

patch looks good, are there other nargs=... that this makes sense with? should it produce an error in the nonsensical cases? should it default to nargs='+'?

isidentical commented May 18, 2019

Copy link
Copy Markdown
Member Author

nargs=N doesn't make any sense (it doesn't need extend but extend can be used like append). but i dont think we should produce a ValueError etc.

furkanonder approved these changes May 20, 2019
View reviewed changes

furkanonder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice fix.

gvanrossum reviewed May 20, 2019
View reviewed changes
Comment thread Doc/library/argparse.rst Outdated
gvanrossum approved these changes May 21, 2019
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yup!

miss-islington commented May 21, 2019

Copy link
Copy Markdown
Contributor

@isidentical: Status check is done, and it's a success ✅ .

miss-islington merged commit aa32a7e into python:master May 21, 2019
isidentical deleted the issue23378 branch December 7, 2019 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
furkanonder furkanonder approved these changes
+1 more reviewer
asottile asottile left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL