FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127604: ensure `-ldl` is passed only once to the linker by picnixz · Pull Request #133071 · python/cpython · GitHub

/ cpython Public

gh-127604: ensure -ldl is passed only once to the linker - #133071

Merged
picnixz merged 3 commits into
python:mainfrom
picnixz:fix/warnings/ldl-linker-127604
Apr 28, 2025
ConversationCommits (3)ChecksFiles changed
Merged

gh-127604: ensure -ldl is passed only once to the linker#133071
picnixz merged 3 commits into
python:mainfrom
picnixz:fix/warnings/ldl-linker-127604

Conversation

picnixz commented Apr 28, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 28, 2025
Closed
picnixz mentioned this pull request Apr 28, 2025
Merged
picnixz commented Apr 28, 2025
View reviewed changes
Comment thread Python/traceback.c Outdated
vstinner approved these changes Apr 28, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

In the current main branch, make shows me many lines starting with gcc -ldl -ldl -ldl -ldl -ldl -ldl. Ooops :-)

With this change, I get gcc -ldl which seems better.

picnixz merged commit af3f6fc into python:main Apr 28, 2025
picnixz deleted the fix/warnings/ldl-linker-127604 branch April 28, 2025 09:55

freakboy3742 commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

This looks like it's addressed the 6x -ldl issue for linux, but the macOS and iOS buildbots are still showing duplicates - I think these are coming out of the handling of dlopen() in libFFI handling.

picnixz commented Apr 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Ah... Why is life so hard. I'm no more on my dev session and I'll be busy this afternoon. Is it possible for someone to fix this as well? An alternate fix is to not pass -ldl for dlopen() if $ac_cv_require_ldl is yes as it's already in LDFLAGS.

I'm very sorry that I failed to fix the libffi part :(

freakboy3742 mentioned this pull request Apr 28, 2025
Merged

freakboy3742 commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

@picnixz #133081 is an attempt at a cleanup for Apple platforms.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL