Repository navigation
gh-132987: Support __index__() in the select.kqueue_event constructor - #133094
Merged
serhiy-storchaka merged 3 commits intoApr 29, 2025
Merged
serhiy-storchaka merged 3 commits into
serhiy-storchaka merged 3 commits into
Conversation
vstinner
approved these changes
Apr 29, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. I just have a minor suggestion on the error message.
Sorry, something went wrong.
Comment thread
Modules/selectmodule.c
Outdated
Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Copy Markdown
Member
Author
|
I afraid that when we will add more convenient general converters, the error message will be changed to something like "unsigned 32-bit integer" or "unsigned 64-bit integer" (depending on platform). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.