| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Makes sense to me (nice analysis in the issue!) but let's let other performance dedicated folks weigh in
Sorry, something went wrong.
|
I'm overall in favour of doing this. Though I wonder if there will be code that relies on the fact that ints between -x to 256 are cached and everything else isn't. I'm somewhat worried some weird code out there relying on the current int interning will break. Does anyone know? (This includes both C API code and Python code). |
Sorry, something went wrong.
IMHO, at a certain point we can't accommodate every way people might rely on some implementation detail. In this specific case we've been fairly clear in documentation (and elsewhere) about not relying on identity. We'll also point out the change in the release notes. Again IMHO, as long as are thoughtful about impact, we should expect that users (taking advantage of impl-specific details like this) take responsibility for adjusting their own code. "We're all consenting adults." |
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry about the inactivity here @dg-pb -- I just remembered this PR after someone was discussing the small integer cache.
I think we should add a news entry and then land this for 3.15. It's technically an internal-only change, but people do notice when things become immortal.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks, this looks good to me.
@Fidget-Spinner Are you happy with this?
Sorry, something went wrong.
|
Don't wait on me, I'm not blocking it! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.