gh-132813: Improve error messages for incorrect types and values of csv.Dialog attributes - #133241
Merged
serhiy-storchaka merged 2 commits intoJun 2, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…s of csv.Dialect attributes Make them similar to PyArg_Parse error messages, mention None as a possible value, show a wrong type and the string length.
serhiy-storchaka
force-pushed
the
csv-error-messages
branch
from
a43c931 to
a0ca9e7
Compare
May 1, 2025 08:07
aterrel
approved these changes
May 20, 2025
aterrel
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
definitely a lot clearer than before.
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2025
…s of csv.Dialog attributes (pythonGH-133241) Make them similar to PyArg_Parse error messages, mention None as a possible value, show a wrong type and the string length. (cherry picked from commit df98a47) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
GH-135050 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…s of csv.Dialog attributes (pythonGH-133241) Make them similar to PyArg_Parse error messages, mention None as a possible value, show a wrong type and the string length.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…s of csv.Dialog attributes (pythonGH-133241) Make them similar to PyArg_Parse error messages, mention None as a possible value, show a wrong type and the string length.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…s of csv.Dialog attributes (pythonGH-133241) Make them similar to PyArg_Parse error messages, mention None as a possible value, show a wrong type and the string length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make them similar to PyArg_Parse error messages, mention None as a possible value, show a wrong type and the string length.