gh-133197: Improve error message for incompatible string / bytes prefixes - #133242
Merged
sobolevn merged 3 commits intoMay 2, 2025
Merged
gh-133197: Improve error message for incompatible string / bytes prefixes#133242sobolevn merged 3 commits into
sobolevn merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lysnikolaou
reviewed
May 1, 2025
lysnikolaou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good! Only one comment inline.
Sorry, something went wrong.
Comment thread
Parser/lexer/lexer.c
lysnikolaou
approved these changes
May 2, 2025
lysnikolaou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM! Thanks @sobolevn!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks for the quick review! |
Sorry, something went wrong.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to only look at two incompatible prefixes at the time. So, here's how debug process looks like (notice that prefixes are highlighted properly):
Alternative implementations where all incompatible prefixes are show at the same time is rather complex and not very clear.