FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-126008: Improve docstrings for Tkinter cget and configure methods by serhiy-storchaka · Pull Request #133303 · python/cpython · GitHub

/ cpython Public

gh-126008: Improve docstrings for Tkinter cget and configure methods - #133303

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:docs-tkinter-configure
Aug 12, 2025
ConversationCommits (5)ChecksFiles changed
Merged

gh-126008: Improve docstrings for Tkinter cget and configure methods#133303
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:docs-tkinter-configure

Conversation

serhiy-storchaka commented May 2, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • Explain the behavior of Widget.configure() depending on arguments.
  • Unify descriptions.
  • Replace "resource" with "option".

pythongh-126008: Improve docstrings for Tkinter cget and configure me…
c7f9234 
…thods

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.13 bugs and security fixes labels May 2, 2025
github-project-automation Bot moved this to Todo in Docs PRs May 2, 2025
bedevere-app Bot mentioned this pull request May 2, 2025
Closed
tomasr8 reviewed May 2, 2025
View reviewed changes
Comment thread Lib/tkinter/__init__.py Outdated
terryjreedy previously requested changes May 3, 2025
View reviewed changes
Comment thread Lib/tkinter/__init__.py Outdated
Comment thread Lib/tkinter/__init__.py
Comment thread Lib/tkinter/__init__.py
Comment thread Lib/tkinter/__init__.py Outdated

bedevere-app Bot commented May 3, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
serhiy-storchaka requested a review from a team May 13, 2025 10:36
bskinn reviewed Jun 2, 2025
View reviewed changes
Comment thread Lib/tkinter/__init__.py
Comment thread Lib/tkinter/__init__.py
Comment thread Lib/tkinter/__init__.py
Comment thread Lib/tkinter/__init__.py Outdated
Comment thread Lib/tkinter/__init__.py Outdated
serhiy-storchaka commented Aug 11, 2025
View reviewed changes
Comment thread Lib/tkinter/__init__.py Outdated
Comment thread Lib/tkinter/__init__.py Outdated
terryjreedy dismissed their stale review August 11, 2025 21:21

We agree that it would be better to have a separate issue/PR to handle option name formatting in docstrings in this entire file.

serhiy-storchaka merged commit 027cacb into python:main Aug 12, 2025
43 of 44 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Aug 12, 2025

miss-islington-app Bot commented Aug 12, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

serhiy-storchaka deleted the docs-tkinter-configure branch August 12, 2025 04:55
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2025
pythongh-126008: Improve docstrings for Tkinter cget and configure me…
12f491a 
…thods (pythonGH-133303)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
(cherry picked from commit 027cacb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2025
pythongh-126008: Improve docstrings for Tkinter cget and configure me…
b2568e8 
…thods (pythonGH-133303)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
(cherry picked from commit 027cacb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented Aug 12, 2025

Copy link
Copy Markdown

GH-137660 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 12, 2025

bedevere-app Bot commented Aug 12, 2025

Copy link
Copy Markdown

GH-137661 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 12, 2025
serhiy-storchaka added a commit that referenced this pull request Aug 12, 2025
[3.13] gh-126008: Improve docstrings for Tkinter cget and configure m…
4a630d7 
…ethods (GH-133303) (GH-137661)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
(cherry picked from commit 027cacb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka commented Aug 12, 2025

Copy link
Copy Markdown
Member Author

Thank you for your review, @terryjreedy, @bskinn.

maurycy added a commit to maurycy/cpython that referenced this pull request Aug 12, 2025
Merge branch 'main' into csv-sniffer-counter-set
11c891d 
* main:
  pythongh-137288: Update 3.14 magic numbers (pythonGH-137665)
  pythongh-135228: When @DataClass(slots=True) replaces a dataclass, make the original class collectible (take 2) (pythonGH-137047)
  pythongh-126008: Improve docstrings for Tkinter cget and configure methods (pythonGH-133303)
  pythongh-131885: Use positional-only markers for ``max()`` and ``min()`` (python#131868)
  pythonGH-137426: Remove code deprecation of `importlib.abc.ResourceLoader` (pythonGH-137567)
  pythongh-125897: Mark range function parameters as positional only (python#125945)
  pythongh-137400: Fix a crash when disabling profiling across all threads (pythongh-137471)
  pythongh-115766: Fix IPv4Interface.is_unspecified (pythonGH-137326)
  pythongh-128813: cleanup C-API docs for PyComplexObject (pythonGH-137579)
  pythongh-135953: Profile a module or script with sampling profiler (python#136777)
  Fix documentation of hash in PyHash_FuncDef (python#137595)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-126008: Improve docstrings for Tkinter cget and configure me…
d7253bd 
…thods (pythonGH-133303)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
encukou pushed a commit that referenced this pull request Oct 7, 2025
[3.14] gh-126008: Improve docstrings for Tkinter cget and configure m…
181cecc 
…ethods (GH-133303) (GH-137660)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
(cherry picked from commit 027cacb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tomasr8 tomasr8 left review comments
AA-Turner AA-Turner left review comments
terryjreedy terryjreedy left review comments
+1 more reviewer
bskinn bskinn left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL