FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131798: JIT: Narrow the return type of `_GET_LEN` to int by Zheaoli · Pull Request #133345 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131798: JIT: Narrow the return type of _GET_LEN to int - #133345

Merged
brandtbucher merged 23 commits into
python:mainfrom
Zheaoli:manjusaka/get-len
May 20, 2025
ConversationCommits (23)ChecksFiles changed
Merged

gh-131798: JIT: Narrow the return type of _GET_LEN to int#133345
brandtbucher merged 23 commits into
python:mainfrom
Zheaoli:manjusaka/get-len

Conversation

Zheaoli commented May 3, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Zheaoli requested a review from Fidget-Spinner as a code owner May 3, 2025 14:32
bedevere-app Bot mentioned this pull request May 3, 2025
Open
tomasr8 reviewed May 3, 2025
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py Outdated
brandtbucher requested changes May 6, 2025
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py Outdated
Comment thread Python/optimizer_bytecodes.c Outdated
Comment thread Python/optimizer_bytecodes.c Outdated

bedevere-app Bot commented May 6, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Zheaoli added 5 commits May 8, 2025 15:03
pythongh-131798: JIT: Narrow the return type of _GET_LEN to int
cabe8f1 
Signed-off-by: Manjusaka <me@manjusaka.me>
Add news
1f8a607 
Signed-off-by: Manjusaka <me@manjusaka.me>
Fix typo
f2f71d9 
Signed-off-by: Manjusaka <me@manjusaka.me>
Fix review idea
1662b47 
Signed-off-by: Manjusaka <me@manjusaka.me>
Fix review idea
52ce698 
Signed-off-by: Manjusaka <me@manjusaka.me>
Zheaoli force-pushed the manjusaka/get-len branch from ad1f5df to 52ce698 Compare May 8, 2025 07:07
Fix review idea
b1640ed 
Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

bedevere-app Bot commented May 8, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@Fidget-Spinner, @brandtbucher: please review the changes made to this pull request.

Zheaoli commented May 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

BTW @brandtbucher @Fidget-Spinner sorry about the force push. I set pull with rebase as default on my environment. I will modify it in next PR(

brandtbucher requested changes May 8, 2025
View reviewed changes
Comment thread Python/optimizer_bytecodes.c
Comment thread Python/optimizer_bytecodes.c Outdated

bedevere-app Bot commented May 8, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Zheaoli added 4 commits May 21, 2025 04:12
fix review idea
d1e3a2b 
Signed-off-by: Manjusaka <me@manjusaka.me>
fix review idea
e0e3745 
Signed-off-by: Manjusaka <me@manjusaka.me>
fix review idea
81c4996 
Signed-off-by: Manjusaka <me@manjusaka.me>
fix review idea
93e1e86 
Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@Fidget-Spinner, @brandtbucher: please review the changes made to this pull request.

bedevere-app Bot requested a review from brandtbucher May 20, 2025 20:21
fix review idea
6b5282f 
Signed-off-by: Manjusaka <me@manjusaka.me>
tomasr8 reviewed May 20, 2025
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py Outdated
Zheaoli added 2 commits May 21, 2025 04:59
fix review idea
2eefeb3 
Signed-off-by: Manjusaka <me@manjusaka.me>
fix review idea
9c58f2c 
Signed-off-by: Manjusaka <me@manjusaka.me>
brandtbucher approved these changes May 20, 2025
View reviewed changes

brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Just one last suggestion for the test:

Comment thread Lib/test/test_capi/test_opt.py
Zheaoli added 3 commits May 21, 2025 05:13
fix review idea
f9822e9 
Signed-off-by: Manjusaka <me@manjusaka.me>
fix review idea
6a06aff 
Signed-off-by: Manjusaka <me@manjusaka.me>
fix review idea
6d92614 
Signed-off-by: Manjusaka <me@manjusaka.me>
Zheaoli requested a review from brandtbucher May 20, 2025 21:14
format code
5cfbad4 
Signed-off-by: Manjusaka <me@manjusaka.me>

Zheaoli commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

Looks good! Just one last suggestion for the test:

Thanks for your patience and review. Learn a lot in this PR. I think I can find a new opcode to write! Thanks again ♥️ @brandtbucher @tomasr8

brandtbucher merged commit e1c0c45 into python:main May 20, 2025
Zheaoli deleted the manjusaka/get-len branch May 20, 2025 22:23
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…
274e5d5 
…133345)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…
6ddc201 
…133345)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…
fbb8996 
…133345)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…
b8e48ba 
…133345)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tomasr8 tomasr8 left review comments
brandtbucher brandtbucher approved these changes
Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees

No one assigned

Labels

topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL