FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-133372: C implementation of types._GeneratorWrapper is added. by efimov-mikhail · Pull Request #133373 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-133372: C implementation of types._GeneratorWrapper is added. - #133373

Closed
efimov-mikhail wants to merge 5 commits into
python:mainfrom
efimov-mikhail:issue_133372_GenWrapper
ConversationCommits (5)ChecksFiles changed
Closed

GH-133372: C implementation of types._GeneratorWrapper is added.#133373
efimov-mikhail wants to merge 5 commits into
python:mainfrom
efimov-mikhail:issue_133372_GenWrapper

Conversation

efimov-mikhail commented May 4, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request May 4, 2025
Closed
efimov-mikhail marked this pull request as draft May 4, 2025 12:05
efimov-mikhail marked this pull request as ready for review May 4, 2025 13:09
ZeroIntensity requested a review from AA-Turner May 4, 2025 14:18
ZeroIntensity requested changes May 4, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think this should go in the generator object implementation. _types should implement it on its own.

Comment thread Objects/genobject.c
Py_CLEAR(gw->gw_gen);
Py_CLEAR(gw->gw_name);
Py_CLEAR(gw->gw_qualname);
if (gw->gw_weakreflist != NULL)

ZeroIntensity May 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Per PEP 7, all if clauses are supposed to have braces.

Comment thread Objects/genobject.c
"__name__ must be set to a string object");
return -1;
}
Py_XSETREF(gw->gw_name, Py_NewRef(value));

ZeroIntensity May 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need a critical section if we're going to modify this in methods.

efimov-mikhail May 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you please give me some additional context on it?
I've just copied this code from gen_set_name function.
Does this mean that critical section is also needed in that func?

efimov-mikhail May 9, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@ZeroIntensity

efimov-mikhail marked this pull request as draft May 4, 2025 15:19
efimov-mikhail mentioned this pull request May 12, 2025
Closed

efimov-mikhail commented May 25, 2025

Copy link
Copy Markdown
Member Author

I close this because of #134563

x42005e1f mentioned this pull request Jan 8, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity requested changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL