| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
| @asyncio.coroutine | ||
| def __anext__(self) -> T_a: | ||
| data = yield from self.value | ||
| async def __anext__(self) -> T_a: |
There was a problem hiding this comment.
The same functionality but without @coroutine
Sorry, something went wrong.
There was a problem hiding this comment.
The typing part LGTM.
Sorry, something went wrong.
Co-Authored-By: Matthias Bussonnier <bussonniermatthias@gmail.com>
|
want to update asyncio-task.rst to use the .. deprecated-removed:: 3.8 3.10 directive ? |
Sorry, something went wrong.
|
Also side-question (and maybe this is better suited for bpo , should asyncio.iscoroutine and asyncio.iscoroutinefunction be deprecated at the same time ? Because presumably once @coroutine is removed, the two other have quasy no chance of encountering a coroutine that would not be properly detected by inspect.iscoroutine. I'm thinking they are still useful from inter-library compatibility and across python version; so maybe deprecate as well but remove even later ? |
Sorry, something went wrong.
There was a problem hiding this comment.
Overall LGTM. Please fix the few nits I commented on.
Sorry, something went wrong.
We can deprecate them when we remove @asyncio.coroutine (in 3.9?) |
Sorry, something went wrong.
Co-Authored-By: Yury Selivanov <yury@magic.io>
Co-Authored-By: Yury Selivanov <yury@magic.io>
|
@caavery the funny thing that @coroutine is already deprecated in docs. Now we have the support of this statement explicitly in code. |
Sorry, something went wrong.
| This decorator should not be used for :keyword:`async def` | ||
| coroutines. | ||
|
|
||
| .. deprecated-removed:: 3.8 3.10 |
There was a problem hiding this comment.
Replace free-form deprecation text with more standardized one.
Sorry, something went wrong.
|
The last call for a review. |
Sorry, something went wrong.
I think it's ready. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
The second attempt. Now deprecate @coroutine only, keep yield from fut as is.
https://bugs.python.org/issue36921