FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)" by encukou · Pull Request #133497 · python/cpython · GitHub

/ cpython Public

gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)" - #133497

Merged
hugovk merged 1 commit into
python:mainfrom
encukou:revert-d270bb5
May 6, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)"#133497
hugovk merged 1 commit into
python:mainfrom
encukou:revert-d270bb5

Conversation

encukou commented May 6, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This reverts commit d270bb5.

Note that the test functions in _code_definitions are not reverted.

Revert "pythongh-132775: Add _PyCode_VerifyStateless() (pythongh-133221…
e7d7e26 
…)"

This reverts commit d270bb5.

Note that the test functions in _code_definitions are not reverted.
encukou requested a review from markshannon as a code owner May 6, 2025 07:19
bedevere-app Bot mentioned this pull request May 6, 2025
Closed
encukou changed the title Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)" gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)" May 6, 2025

encukou commented May 6, 2025

Copy link
Copy Markdown
Member Author

@hugovk I need to step away for a doctor's appointment. Here's what I have, I haven't checked this very well.

hugovk commented May 6, 2025

Copy link
Copy Markdown
Member

@encukou Thank you!

hugovk commented May 6, 2025

Copy link
Copy Markdown
Member

!buildbot ios

bedevere-bot commented May 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit e7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression: ios

The builders matched are:

  • iOS ARM64 Simulator PR

hugovk commented May 6, 2025

Copy link
Copy Markdown
Member

!buildbot android

bedevere-bot commented May 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit e7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

ambv commented May 6, 2025

Copy link
Copy Markdown
Contributor

iOS buildbot green! No Android results yet.

ambv commented May 6, 2025

Copy link
Copy Markdown
Contributor

It's weird since the Android builders aren't building anything else at the moment. Looking at buildmaster.

ambv commented May 6, 2025

Copy link
Copy Markdown
Contributor

Master claims it added jobs:

2025-05-06 07:36:07+0000 [HTTP11ClientProtocol (BufferingTLSTransport),client] Received 1 changes from GitHub PR #133497
2025-05-06 07:36:07+0000 [-] added change with revision e7d7e26eee5fa9dcd6b23d1dd00f96cd083aff8b to database
2025-05-06 07:36:07+0000 [-] injected change 41998

Weird. Let's try again.

ambv commented May 6, 2025

Copy link
Copy Markdown
Contributor

!buildbot android

bedevere-bot commented May 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit e7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

ambv commented May 6, 2025

Copy link
Copy Markdown
Contributor

Now it worked, builds started.

hugovk commented May 6, 2025

Copy link
Copy Markdown
Member

And Android green.

hugovk merged commit 3c73cf5 into python:main May 6, 2025
This was referenced May 6, 2025
Merged
Merged
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 6, 2025
Revert "pythongh-132775: Revert "pythongh-132775: Add _PyCode_VerifyS…
eab4c13 
…tateless() (pythongh-133221)" (python#133497)"

This reverts commit 3c73cf5.
This was referenced May 6, 2025
Merged
Merged
ericsnowcurrently added a commit that referenced this pull request May 8, 2025
gh-132775: Unrevert "Add _PyCode_VerifyStateless()" (gh-133528)
27128e4 
This reverts commit 3c73cf5 (gh-133497), which itself reverted
the original commit d270bb5 (gh-133221).

We reverted the original change due to failing android tests.
The checks in _PyCode_CheckNoInternalState() were too strict,
so we've relaxed them.
ericsnowcurrently added a commit that referenced this pull request May 8, 2025
[3.14] gh-132775: Unrevert "Add _PyCode_VerifyStateless()" (gh-133625)
c39bc81 
This reverts commit 3c73cf5 (gh-133497), which itself reverted
the original commit d270bb5 (gh-133221).

We reverted the original change due to failing android tests.
The checks in _PyCode_CheckNoInternalState() were too strict,
so we've relaxed them.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-132775: Revert "pythongh-132775: Add _PyCode_VerifyStateless…
eec7b86 
…() (pythongh-133221)" (python#133497)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-132775: Unrevert "Add _PyCode_VerifyStateless()" (pythongh-1…
3bea157 
…33528)

This reverts commit 3c73cf5 (pythongh-133497), which itself reverted
the original commit d270bb5 (pythongh-133221).

We reverted the original change due to failing android tests.
The checks in _PyCode_CheckNoInternalState() were too strict,
so we've relaxed them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL