Repository navigation
gh-133532: Run GC fast cycles test in subprocess. - #133533
Merged
nascheme merged 5 commits intoMay 8, 2025
Merged
nascheme merged 5 commits into
nascheme merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
chris-eibl
reviewed
May 6, 2025
Comment thread
Lib/test/_test_gc_fast_cycles.py
Outdated
markshannon
approved these changes
May 7, 2025
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good.
Maybe we could reduce the 27k limit, but I don't know if it is worth messing with here.
Sorry, something went wrong.
nascheme
enabled auto-merge (squash)
May 7, 2025 16:58
Copy link
Copy Markdown
|
Thanks @nascheme for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 8, 2025
) This makes the test more reliable since there are not extra objects on the heap leftover from other tests. (cherry picked from commit 8598e57) Co-authored-by: Neil Schemenauer <nas-github@arctrix.com>
Copy link
Copy Markdown
|
GH-133716 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
nascheme
added a commit
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the test more reliable since there are not extra objects on the heap leftover from other tests.