FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 by maxbachmann · Pull Request #133574 · python/cpython · GitHub

/ cpython Public

gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 #133574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 4 commits into from
May 14, 2025
+2 −0
Conversation 4 Commits 4 Checks 0 Files changed 2
Merged

gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 #133574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5dc09ad
add missing exception in _sys_getwindowsversion_from_kernel32
maxbachmann May 7, 2025
064806d
📜🤖 Added by blurb_it.
blurb-it[bot] May 7, 2025
5e5552b
Update Misc/NEWS.d/next/Windows/2025-05-07-13-04-22.gh-issue-133580.j…
maxbachmann May 11, 2025
18c9e02
Update Python/sysmodule.c
maxbachmann May 14, 2025
File filter

Filter by extension

Filter by extension .c  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Windows/2025-05-07-13-04-22.gh-issue-133580.jBMujJ.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix :func:`sys.getwindowsversion` failing without setting an exception when called on some WinAPI partitions.
1 change: 1 addition & 0 deletions Python/sysmodule.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1643,6 +1643,7 @@ static PyObject *
_sys_getwindowsversion_from_kernel32(void)
{
#ifndef MS_WINDOWS_DESKTOP
PyErr_SetString(PyExc_OSError, "cannot read version info on this platform");
return NULL;
#else
HANDLE hKernel32;
Expand Down
Back | FazBrowse Home | New Git URL