FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131178: Add tests for `site` command-line interface by ggqlq · Pull Request #133582 · python/cpython · GitHub

/ cpython Public

gh-131178: Add tests for site command-line interface - #133582

Merged
ZeroIntensity merged 15 commits into
python:mainfrom
ggqlq:add_tests_for_site_cli
Aug 15, 2025
ConversationCommits (15)ChecksFiles changed
Merged

gh-131178: Add tests for site command-line interface #133582
ZeroIntensity merged 15 commits into
python:mainfrom
ggqlq:add_tests_for_site_cli

Conversation

ggqlq commented May 7, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

ggqlq requested a review from FFY00 as a code owner May 7, 2025 14:41
bedevere-app Bot added the tests Tests in the Lib/test dir label May 7, 2025
bedevere-app Bot mentioned this pull request May 7, 2025
Open
9 tasks

This comment was marked as resolved.

Sign in to view
ggqlq marked this pull request as draft May 7, 2025 16:09

This comment was marked as resolved.

Sign in to view
4 similar comments

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view
ggqlq force-pushed the add_tests_for_site_cli branch from bd612e2 to b1ec14d Compare May 7, 2025 19:00

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view
ggqlq marked this pull request as ready for review May 8, 2025 06:51
ZeroIntensity reviewed May 11, 2025
View reviewed changes
Comment thread Lib/test/test_site.py Outdated
Comment thread Lib/test/test_site.py Outdated
Comment thread Lib/test/test_site.py Outdated
Comment thread Lib/test/test_site.py Outdated

ZeroIntensity commented May 11, 2025

Copy link
Copy Markdown
Member

Also: don't force push, it just makes reviewing harder and the bot louder. We squash-merge at the end.

ggqlq requested a review from ZeroIntensity May 13, 2025 06:59
ZeroIntensity added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 5, 2025

bedevere-bot commented Jun 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit d0999d2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133582%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 5, 2025
donbarbos mentioned this pull request Aug 15, 2025
Closed
ZeroIntensity approved these changes Aug 15, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good, thanks!

ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 15, 2025
ZeroIntensity merged commit 03f5519 into python:main Aug 15, 2025
50 checks passed

miss-islington-app Bot commented Aug 15, 2025

Copy link
Copy Markdown

Thanks @ggqlq for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2025
pythongh-131178: Add tests for site command-line interface (pythonG…
2efeb8f 
…H-133582)

(cherry picked from commit 03f5519)

Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2025
pythongh-131178: Add tests for site command-line interface (pythonG…
797f64e 
…H-133582)

(cherry picked from commit 03f5519)

Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>

bedevere-app Bot commented Aug 15, 2025

Copy link
Copy Markdown

GH-137832 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 15, 2025

bedevere-app Bot commented Aug 15, 2025

Copy link
Copy Markdown

GH-137833 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 15, 2025
ZeroIntensity pushed a commit that referenced this pull request Aug 15, 2025
[3.13] gh-131178: Add tests for site command-line interface (GH-133582
8d6e107 
) (GH-137833)

gh-131178: Add tests for `site` command-line interface  (GH-133582)
(cherry picked from commit 03f5519)

Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>

ggqlq commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity Thank you for your review!

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-131178: Add tests for site command-line interface (python…
ed3b781 
…GH-133582)
ZeroIntensity pushed a commit that referenced this pull request Oct 7, 2025
[3.14] gh-131178: Add tests for site command-line interface (GH-133582
df739f3 
) (GH-137832)

gh-131178: Add tests for `site` command-line interface  (GH-133582)
(cherry picked from commit 03f5519)

Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
itamaro mentioned this pull request Oct 15, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity approved these changes
FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL