FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131798: JIT: Assign type to sliced string by fluhus · Pull Request #133609 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131798: JIT: Assign type to sliced string - #133609

Closed
fluhus wants to merge 3 commits into
python:mainfrom
fluhus:amit
ConversationCommits (3)ChecksFiles changed
Closed

gh-131798: JIT: Assign type to sliced string#133609
fluhus wants to merge 3 commits into
python:mainfrom
fluhus:amit

Conversation

fluhus commented May 7, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Slicing a string always returns a string.
Make the optimizer assign a string type to the result of slicing a string.

Follow up to-do: apply this to lists and tuples too.

@brandtbucher

fluhus requested a review from Fidget-Spinner as a code owner May 7, 2025 19:49
bedevere-app Bot mentioned this pull request May 7, 2025
Open
sharktide suggested changes May 8, 2025
View reviewed changes

sharktide left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a user-facing change. This probably needs a NEWS entry

*sorry, this isn't a user-facing change. I was tired and not thinking straight. But still would be best for a news entry

brandtbucher commented May 8, 2025

Copy link
Copy Markdown
Member

This isn’t a user-facing change (but a NEWS entry doesn’t hurt).

sharktide commented May 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This isn’t a user-facing change (but a NEWS entry doesn’t hurt).

sorry, did I type that? my brain wasn't working. Yes, you're right, a news entry would be best here and this isn't a user facing change.

brandtbucher approved these changes May 8, 2025
View reviewed changes
Comment thread Python/optimizer_bytecodes.c
Comment on lines +1100 to +1102
// Slicing a string always returns a string.
// TODO: We can apply this to lists and tuples as well.
// We'll start with string to simplify the process.

brandtbucher May 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wanna just add the others to this PR too? It's just two lines here and a couple of tests.

fluhus closed this May 25, 2025
fluhus deleted the amit branch May 25, 2025 19:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher approved these changes
Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
+1 more reviewer
sharktide sharktide approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL